Toggle icon for toolbar menu missing for all tabs except Manage

This issue was introduced by committing the patch in #3257504: Empty toolbar tray displays a stray orientation toggle → .

If you remove the .has('.toolbar-menu') part from Core again, you'll have the buttons back (but also a stray button if there is no menu at all).

Also, this happens for users who may see the toolbar but are not admins as they will see the "Manage" tab although it has no items. Thus, the menu is not really existant.

See #2135445: Toolbar displays Manage tab even if the user is not permitted to see it →

Here's a patch that reverts the introduction of the "has-menu" check. This is not a final solution but works fine in conjunction with the patch in https://www.drupal.org/project/drupal/issues/2135445#comment-13003616 → to show the admin toolbar for users without admin permissions.

Fix from the #8 for Drupal 10

The last submitted patch, 8: drupal-toggle_icon-3305152-8-D10.patch, failed testing. View results →

Ignore the escape-admin-path branch, that was accidental.

The 3305152-toggle-icon-for merge request, however is ready for review.

This fixes the underlying issue without undoing the benefits of #3257504: Empty toolbar tray displays a stray orientation toggle → . Now, if the manage tab has an empty tray, the tab itself is not visible either.

Note that checking for .has(.toolbar-menu) was not an ideal approach as there were scenarios where this JavaScript is running before all the relevant .toolbar-menu classes are present.

Failures in MR seem legit to the issue.

Test updated to account for empty trays not being displayed anymore.

Rebase seems good.

Sorry wrong ticket. Will take a look today.

Verified this issue on a fresh install of 10.1
Verified MR solved the issue.

This might not be relevant, but when looking at screenshot #17 don't you think that "Edit shortcuts" link is not in place?

Tried to apply the patch from Comment #7, but the issue still existed. Noticing that it was applying only on the first element, added a loop so that it would apply to all the trays on the toolbar to fix the issue. This was done for Drupal Core 9.5.8.

Re-rolled #20 for 11.x-dev

The last submitted patch, 22: 3305152-22.patch, failed testing. View results →

Note on review of #20, if your Shortcut toolbar has no items in it, you will get a fatal JS error:

$orientationToggleButton[0] is not defined

That logic needs an if !== undefined wrapper.

Noted the issue on Drupal 10.2

This patch caused significant issues for us for non admin users. I'm yet to look into what is different in the HTML structure between admin and non admin users that might be affecting it.