Refactor Claro's form stylesheet

Comment over 1 year ago →
🇮🇳India Aditya4478
Comment over 1 year ago →
🇮🇳India Santosh_Verma
The patch #17 was tested on D11.x, but it failed. I have created a new patch file, and I am uploading it
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
CI aborted
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Patch Failed to Apply
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,565 pass
Status changed to Needs review over 1 year ago1:08pm 29 June 2023
Comment over 1 year ago →
🇮🇳India Santosh_Verma
Status changed to Needs work over 1 year ago2:33pm 29 June 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Please include before/after screenshots.
Comment over 1 year ago →
🇮🇳India Santosh_Verma
@smustgrave i have added the before and after screenshot as you asked

Before

After
Status changed to Needs review over 1 year ago8:08am 30 June 2023
Comment over 1 year ago →
🇮🇳India Santosh_Verma
Status changed to RTBC over 1 year ago6:17pm 30 June 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Nesting appears to be good.

Will lean on the screenshots on #26 too.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,571 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,801 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,801 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,802 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,802 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,807 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,812 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,815 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,815 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,822 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,873 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,878 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,881 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,885 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
55:56
52:36
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,911 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,946 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,953 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,951 pass, 2 fail
Comment over 1 year ago →
System Message
The last submitted patch, 23: 3304920-23.patch, failed testing. View results →
Comment over 1 year ago →
🇺🇸United States smustgrave
Random failure
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,958 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,958 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,958 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,959 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,971 pass
Status changed to Needs work over 1 year ago4:25pm 18 August 2023

🇪🇸Spain ckrina Barcelona

Thanks for the work here! A few minor changes.

+++ b/core/themes/claro/css/components/form.pcss.css
@@ -111,12 +109,7 @@ tr .form-item,
+    margin-inline-start: var(--space-xs); /* LTR */

This /* LTR */ comment should be removed.

+++ b/core/themes/claro/css/components/form.pcss.css
@@ -127,18 +120,19 @@ tr .form-item,
+  ¶

Empty spaces?

+++ b/core/themes/claro/css/components/form.pcss.css
@@ -164,31 +158,32 @@ tr .form-item,
+    margin-inline-end: var(--space-xs); /* LTR */

Same, I don't think this /* LTR */ is accurate in here anymore since it's what we're trying to get rid of and can be confusing.

First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,049 pass
@rpayanm opened merge request.
Status changed to Needs review over 1 year ago6:42pm 19 August 2023
Comment over 1 year ago →
🇺🇸United States rpayanm
Please review.
Comment over 1 year ago →
System Message

ckrina → committed 4e12f074 on 11.x
Issue #3304920 by Aditya4478, Sakthivel M, rpayanm, Santosh_Verma,...
Status changed to Fixed over 1 year ago12:57pm 21 August 2023
Comment over 1 year ago →
🇪🇸Spain ckrina Barcelona
Committed 4e12f07 and pushed to 11.x. Thanks!
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Refactor Claro's form stylesheet

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Comments & Activities