Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 19 August 2022, over 2 years ago
Updated 20 August 2024, 5 months ago
FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\drupal_libcal\config\optional\field.field.node.event.field_libcal_url.yml
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 18 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\drupal_libcal\config\optional\field.storage.node.field_end_date.yml
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 21 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\drupal_libcal\config\optional\field.storage.node.field_libcal_url.yml
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 20 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\drupal_libcal\css\event-page.css
-------------------------------------------------------------------------------------
FOUND 28 ERRORS AFFECTING 26 LINES
-------------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
  1 | ERROR | [x] Selectors must be on a single line
  2 | ERROR | [x] Blank lines are not allowed between class names
  4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 7
 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 24 | ERROR | [x] Whitespace found at end of line
 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 27 | ERROR | [x] Whitespace found at end of line
 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 35 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 39 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 44 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 28 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\drupal_libcal\libcal.libraries.yml
-------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\drupal_libcal\libcal.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 110 ERRORS AND 3 WARNINGS AFFECTING 86 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  10 | ERROR   | [x] Missing function doc comment
  18 | ERROR   | [x] Opening brace should be on the same line as the declaration
  19 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  20 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  21 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  22 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  23 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  24 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  25 | ERROR   | [x] Case breaking statement indented incorrectly; expected 10 spaces, found 12
  27 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  28 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  35 | ERROR   | [x] Opening brace should be on the same line as the declaration
  36 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  37 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
  38 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  44 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
  44 | ERROR   | [x] Function comment short description must start with exactly one space
  44 | ERROR   | [x] Doc comment short description must end with a full stop
  47 | ERROR   | [x] Opening brace should be on the same line as the declaration
  48 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 3
  53 | ERROR   | [x] Doc comment short description must end with a full stop
  55 | ERROR   | [ ] Invalid function name, expected start_download_lib_cal_events but found startDownloadLibCalEvents
  59 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
  59 | ERROR   | [x] Inline comments must start with a capital letter
  59 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  60 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  63 | ERROR   | [x] There should be no white space before a closing ")"
  65 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
  65 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  65 | ERROR   | [x] There should be no white space before a closing ")"
  68 | ERROR   | [x] Concat operator must be surrounded by a single space
  71 | ERROR   | [x] Expected newline after closing brace
  72 | ERROR   | [x] Concat operator must be surrounded by a single space
  78 | ERROR   | [x] There should be no white space before a closing ")"
  80 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
  80 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  80 | ERROR   | [x] There should be no white space before a closing ")"
  83 | ERROR   | [x] Expected 1 space after "="; 2 found
  86 | ERROR   | [x] Expected newline after closing brace
  87 | ERROR   | [x] Expected 1 space after "="; 0 found
  95 | ERROR   | [x] Doc comment short description must end with a full stop
  96 | ERROR   | [x] There must be exactly one blank line before the tags in a doc comment
  96 | ERROR   | [ ] Missing parameter comment
  96 | ERROR   | [ ] Missing parameter type
  97 | ERROR   | [ ] Missing parameter comment
  98 | ERROR   | [x] Separate the @param and @return sections by a blank line.
  98 | ERROR   | [ ] Description for the @return value is missing
 100 | ERROR   | [ ] Invalid function name, expected create_slug but found createSlug
 101 | ERROR   | [x] Opening brace should be on the same line as the declaration
 102 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 103 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 107 | ERROR   | [x] Doc comment short description must end with a full stop
 108 | ERROR   | [x] There must be exactly one blank line before the tags in a doc comment
 108 | ERROR   | [ ] Missing parameter comment
 108 | ERROR   | [ ] Missing parameter type
 110 | ERROR   | [ ] Invalid function name, expected generate_event_alias but found generateEventAlias
 111 | ERROR   | [x] Opening brace should be on the same line as the declaration
 112 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 113 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 114 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters
 114 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 114 | ERROR   | [x] No space found before comment text; expected "// $path = \Drupal::service('path_alias.repository')->save("/node/" . $node->id(), $tag, "en");" but found "//$path =
     |         |     \Drupal::service('path_alias.repository')->save("/node/" . $node->id(), $tag, "en");"
 115 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 116 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
 117 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
 118 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
 120 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 8
 122 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 128 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 129 | ERROR   | [x] Opening brace should be on the same line as the declaration
 130 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 131 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 131 | ERROR   | [x] No space found before comment text; expected "// if (get_class($node) == 'Drupal\node\Entity\Node') {" but found "//if (get_class($node) == 'Drupal\node\Entity\Node') {"
 131 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 132 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 133 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 135 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 135 | ERROR   | [x] Inline comments must start with a capital letter
 136 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 140 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 141 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 142 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 143 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 146 | ERROR   | [x] Missing function doc comment
 146 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 147 | ERROR   | [x] Opening brace should be on the same line as the declaration
 148 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 149 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 149 | ERROR   | [x] No space found before comment text; expected "// if (get_class($node) == 'Drupal\node\Entity\Node') {" but found "//if (get_class($node) == 'Drupal\node\Entity\Node') {"
 149 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 150 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 151 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 152 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 156 | ERROR   | [x] Doc comment short description must end with a full stop
 161 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 161 | ERROR   | [x] Missing function doc comment
 161 | ERROR   | [x] Expected 1 blank line before function; 0 found
 162 | ERROR   | [x] Opening brace should be on the same line as the declaration
 163 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 163 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 164 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 168 | ERROR   | [x] Doc comment short description must end with a full stop
 169 | ERROR   | [x] There must be exactly one blank line before the tags in a doc comment
 172 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 172 | ERROR   | [x] Missing function doc comment
 172 | ERROR   | [x] Expected 1 blank line before function; 0 found
 173 | ERROR   | [x] Opening brace should be on the same line as the declaration
 174 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 175 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 176 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 177 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 177 | ERROR   | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 101 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\drupal_libcal\README.md
--------------------------------------------------------------------------
FOUND 1 ERROR AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------
  4 | WARNING | [ ] Line exceeds 80 characters; contains 133 characters
  8 | WARNING | [ ] Line exceeds 80 characters; contains 143 characters
 13 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 15 | WARNING | [ ] Line exceeds 80 characters; contains 197 characters
 21 | WARNING | [ ] Line exceeds 80 characters; contains 189 characters
 22 | WARNING | [ ] Line exceeds 80 characters; contains 225 characters
 22 | ERROR   | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\drupal_libcal\src\EventDownloadService.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 261 ERRORS AND 11 WARNINGS AFFECTING 199 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
   7 | WARNING | [x] Unused use statement
  13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
  15 | ERROR   | [x] Opening brace should be on the same line as the declaration
  17 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  20 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  21 | ERROR   | [x] Opening brace should be on the same line as the declaration
  23 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  25 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  25 | ERROR   | [x] Missing function doc comment
  26 | ERROR   | [x] Opening brace should be on the same line as the declaration
  27 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  29 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  30 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  30 | ERROR   | [x] Concat operator must be surrounded by a single space
  32 | ERROR   | [x] Array indentation error, expected 18 spaces but found 20
  33 | ERROR   | [x] Array indentation error, expected 18 spaces but found 20
  34 | ERROR   | [x] Array indentation error, expected 18 spaces but found 20
  35 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
  37 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
  37 | ERROR   | [x] Expected 1 space(s) after cast statement; 0 found
  38 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  38 | ERROR   | [x] Expected newline after closing brace
  39 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  40 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  40 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  41 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  42 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  44 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  44 | ERROR   | [x] Missing function doc comment
  45 | ERROR   | [x] Opening brace should be on the same line as the declaration
  46 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  47 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  48 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  49 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  50 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  51 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  52 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  53 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  54 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  56 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  57 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  58 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  58 | ERROR   | [x] Concat operator must be surrounded by a single space
  59 | WARNING | [x] A comma should follow the last multiline array item. Found: $headers
  61 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
  61 | ERROR   | [x] Expected 1 space(s) after cast statement; 0 found
  62 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  62 | ERROR   | [x] Expected newline after closing brace
  63 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  64 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  64 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  65 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  66 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  68 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  68 | ERROR   | [ ] Missing short description in doc comment
  69 | ERROR   | [ ] Missing parameter comment
  71 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  72 | ERROR   | [x] Opening brace should be on the same line as the declaration
  74 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  75 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  77 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  79 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  80 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
  81 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
  83 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
  84 | ERROR   | [x] Line indented incorrectly; expected 10 spaces, found 20
  85 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
  86 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  87 | ERROR   | [x] Whitespace found at end of line
  88 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 13
  89 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
  90 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  90 | ERROR   | [x] Closing brace indented incorrectly; expected 13 spaces, found 12
  90 | ERROR   | [x] Expected newline after closing brace
  91 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
  92 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  93 | ERROR   | [x] Whitespace found at end of line
  94 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  94 | ERROR   | [x] Inline comments must start with a capital letter
  94 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  95 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 13
  96 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
  97 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  97 | ERROR   | [x] Closing brace indented incorrectly; expected 13 spaces, found 12
  98 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 100 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 102 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 102 | ERROR   | [ ] Missing short description in doc comment
 103 | ERROR   | [ ] Missing parameter comment
 103 | ERROR   | [ ] Missing parameter type
 105 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 106 | ERROR   | [x] Opening brace should be on the same line as the declaration
 107 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 107 | ERROR   | [x] Inline comments must start with a capital letter
 107 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 108 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 109 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 110 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 111 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 112 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 113 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
 114 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 115 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 116 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 118 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 118 | ERROR   | [ ] Missing short description in doc comment
 119 | ERROR   | [ ] Missing parameter comment
 119 | ERROR   | [ ] Missing parameter type
 120 | ERROR   | [ ] Description for the @return value is missing
 122 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 123 | ERROR   | [x] Opening brace should be on the same line as the declaration
 124 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 125 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 126 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 127 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 128 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 130 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 132 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 132 | ERROR   | [x] Missing function doc comment
 133 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 134 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 135 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 135 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 136 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 136 | ERROR   | [x] Expected newline after closing brace
 137 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 137 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 138 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 139 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 141 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 141 | ERROR   | [x] Missing function doc comment
 142 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 142 | ERROR   | [ ] The array declaration extends to column 103 (the limit is 80). The array content should be split up over multiple lines
 142 | ERROR   | [x] Short array syntax must be used to define arrays
 142 | ERROR   | [x] There should be no white space before a closing ")"
 143 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 145 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 145 | ERROR   | [x] Missing function doc comment
 146 | ERROR   | [x] Opening brace should be on the same line as the declaration
 147 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 148 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 149 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 149 | ERROR   | [x] No space found before comment text; expected "// $query->condition('field_past_event', false);" but found "//$query->condition('field_past_event', false);"
 150 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 150 | ERROR   | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces
 151 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 152 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 152 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 153 | WARNING | [x] There must be no blank line following an inline comment
 153 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 153 | ERROR   | [x] No space found before comment text; expected "// $eventnode->set('field_past_event', $flag);" but found "//$eventnode->set('field_past_event', $flag);"
 155 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 155 | ERROR   | [x] Inline comments must start with a capital letter
 156 | WARNING | [ ] Line exceeds 80 characters; contains 281 characters
 156 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 156 | ERROR   | [x] No space found before comment text; expected "// \Drupal::messenger()->addMessage($eventnode->id() . ") ". $eventnode->getTitle() . " " . time(). " " .
     |         |     $eventnode->get("field_start_date")->getValue()[0]['value']. " = " . (time() > strtotime($eventnode->get("field_start_date")->getValue()[0]['value'])) , "warning");" but found
     |         |     "//\Drupal::messenger()->addMessage($eventnode->id() . ") ". $eventnode->getTitle() . " " . time(). " " . $eventnode->get("field_start_date")->getValue()[0]['value']. " = " . (time() >
     |         |     strtotime($eventnode->get("field_start_date")->getValue()[0]['value'])) , "warning");"
 156 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 157 | ERROR   | [x] Spaces must be used to indent lines; tabs are not allowed
 157 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 5
 158 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 14
 158 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 159 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 159 | ERROR   | [x] Closing brace indented incorrectly; expected 5 spaces, found 12
 160 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 161 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 14
 161 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 162 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 164 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 165 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 166 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 168 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 168 | ERROR   | [ ] Missing short description in doc comment
 169 | ERROR   | [ ] Missing parameter comment
 169 | ERROR   | [ ] Missing parameter type
 171 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 172 | ERROR   | [x] Opening brace should be on the same line as the declaration
 173 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 174 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 176 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 178 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 179 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 181 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 183 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 183 | ERROR   | [x] Short array syntax must be used to define arrays
 185 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 186 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 186 | ERROR   | [x] Expected one space after the comma, 0 found
 186 | ERROR   | [x] Short array syntax must be used to define arrays
 187 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 188 | ERROR   | [x] Whitespace found at end of line
 188 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 190 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 200 | ERROR   | [x] Inline comments must start with a capital letter
 200 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 205 | WARNING | [x] A comma should follow the last multiline array item. Found: 'full_html'
 209 | ERROR   | [x] Inline comments must start with a capital letter
 209 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 209 | ERROR   | [x] Comments may not appear after statements
 217 | ERROR   | [x] No space found before comment text; expected "// 'field_future_dates' => $event->future_dates," but found "//'field_future_dates' => $event->future_dates,"
 224 | ERROR   | [x] Expected 1 space before "?"; 0 found
 224 | ERROR   | [x] Expected 1 space before ":"; 0 found
 225 | ERROR   | [x] Expected 1 space before ":"; 0 found
 226 | WARNING | [x] A comma should follow the last multiline array item. Found: 0
 228 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 229 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 231 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 233 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 233 | ERROR   | [ ] Missing short description in doc comment
 234 | ERROR   | [ ] Missing parameter comment
 234 | ERROR   | [ ] Missing parameter type
 235 | ERROR   | [ ] Missing parameter comment
 235 | ERROR   | [ ] Missing parameter type
 237 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 238 | ERROR   | [x] Opening brace should be on the same line as the declaration
 240 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 241 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 243 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 245 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 246 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 248 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 250 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 250 | ERROR   | [x] Short array syntax must be used to define arrays
 252 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 253 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 253 | ERROR   | [x] Expected one space after the comma, 0 found
 253 | ERROR   | [x] Short array syntax must be used to define arrays
 254 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 256 | WARNING | [x] There must be no blank line following an inline comment
 256 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 256 | ERROR   | [x] Inline comments must start with a capital letter
 256 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 258 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 259 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 260 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 261 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 262 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 263 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 266 | WARNING | [x] A comma should follow the last multiline array item. Found: 'full_html'
 268 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 269 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 270 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 270 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
 270 | ERROR   | [x] Inline comments must start with a capital letter
 270 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 270 | ERROR   | [x] Comments may not appear after statements
 271 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 272 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 274 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 275 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 276 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 277 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 278 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 279 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 279 | ERROR   | [x] No space found before comment text; expected "// $eventNode->set('field_future_dates', $event->future_dates);" but found "//$eventNode->set('field_future_dates', $event->future_dates);"
 280 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 281 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 282 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 283 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 284 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 285 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 286 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 286 | ERROR   | [x] Expected one space after the comma, 0 found
 286 | ERROR   | [x] Expected 1 space before "?"; 0 found
 287 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 287 | ERROR   | [x] Expected 1 space before ":"; 0 found
 288 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 288 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 290 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 12
 291 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 292 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 292 | ERROR   | [x] Expected 1 blank line after function; 2 found
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 251 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\drupal_libcal\src\EventDownloadServiceInterface.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------
 1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 7 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\drupal_libcal\src\Form\LibcalAPIConfigForm.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 69 ERRORS AND 10 WARNINGS AFFECTING 60 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  10 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
  12 | ERROR   | [x] Opening brace should be on the same line as the declaration
  13 | ERROR   | [ ] Missing member variable doc comment
  19 | ERROR   | [x] Opening brace should be on the same line as the declaration
  29 | ERROR   | [x] Opening brace should be on the same line as the declaration
  37 | ERROR   | [x] Opening brace should be on the same line as the declaration
  40 | ERROR   | [x] Short array syntax must be used to define arrays
  43 | WARNING | [x] A comma should follow the last multiline array item. Found: )
  46 | ERROR   | [x] Short array syntax must be used to define arrays
  49 | ERROR   | [ ] The array declaration extends to column 108 (the limit is 80). The array content should be split up over multiple lines
  51 | ERROR   | [x] Short array syntax must be used to define arrays
  56 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  56 | WARNING | [x] A comma should follow the last multiline array item. Found: ""
  59 | ERROR   | [x] Short array syntax must be used to define arrays
  64 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  64 | WARNING | [x] A comma should follow the last multiline array item. Found: ""
  66 | ERROR   | [x] Short array syntax must be used to define arrays
  71 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  71 | WARNING | [x] A comma should follow the last multiline array item. Found: ""
  74 | ERROR   | [x] Short array syntax must be used to define arrays
  80 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  80 | WARNING | [x] A comma should follow the last multiline array item. Found: ""
  83 | ERROR   | [x] Short array syntax must be used to define arrays
  89 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  89 | WARNING | [x] A comma should follow the last multiline array item. Found: ""
  92 | ERROR   | [x] Short array syntax must be used to define arrays
  97 | ERROR   | [x] Short array syntax must be used to define arrays
  97 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 100 | ERROR   | [x] Short array syntax must be used to define arrays
 103 | ERROR   | [ ] The array declaration extends to column 109 (the limit is 80). The array content should be split up over multiple lines
 105 | ERROR   | [x] Short array syntax must be used to define arrays
 106 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 109 | ERROR   | [x] Short array syntax must be used to define arrays
 114 | ERROR   | [x] Short array syntax must be used to define arrays
 114 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 118 | ERROR   | [x] No space found before comment text; expected "// return parent::buildForm($form, $form_state);" but found "//return parent::buildForm($form, $form_state);"
 118 | ERROR   | [x] Inline comments must start with a capital letter
 118 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 122 | ERROR   | [x] Doc comment short description must end with a full stop
 123 | ERROR   | [x] There must be exactly one blank line before the tags in a doc comment
 123 | ERROR   | [ ] Missing parameter comment
 124 | ERROR   | [ ] Missing parameter comment
 124 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 127 | ERROR   | [x] Opening brace should be on the same line as the declaration
 129 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 130 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 131 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 136 | ERROR   | [x] Doc comment short description must end with a full stop
 137 | ERROR   | [x] There must be exactly one blank line before the tags in a doc comment
 137 | ERROR   | [ ] Missing parameter comment
 138 | ERROR   | [ ] Missing parameter comment
 138 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 141 | ERROR   | [x] Opening brace should be on the same line as the declaration
 149 | ERROR   | [x] Doc comment short description must end with a full stop
 150 | ERROR   | [x] There must be exactly one blank line before the tags in a doc comment
 150 | ERROR   | [ ] Missing parameter comment
 151 | ERROR   | [ ] Missing parameter comment
 151 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 154 | ERROR   | [x] Opening brace should be on the same line as the declaration
 159 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 163 | ERROR   | [x] Doc comment short description must end with a full stop
 164 | ERROR   | [x] There must be exactly one blank line before the tags in a doc comment
 164 | ERROR   | [ ] Missing parameter comment
 165 | ERROR   | [ ] Missing parameter comment
 165 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 168 | ERROR   | [x] Opening brace should be on the same line as the declaration
 173 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 177 | ERROR   | [x] Doc comment short description must end with a full stop
 178 | ERROR   | [x] There must be exactly one blank line before the tags in a doc comment
 178 | ERROR   | [ ] Missing parameter comment
 179 | ERROR   | [ ] Missing parameter comment
 179 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 182 | ERROR   | [x] Opening brace should be on the same line as the declaration
 187 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 190 | ERROR   | [x] Inline comments must start with a capital letter
 191 | ERROR   | [x] No space found before comment text; expected "// $service->libcalEventToNode($result);" but found "//$service->libcalEventToNode($result);"
 198 | ERROR   | [x] Opening brace should be on the same line as the declaration
 205 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 65 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\drupal_libcal\tests\src\Functional\LoadTest.php
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

Steps to reproduce

Run following command
phpcs --standard=“Drupal,DrupalPractice” --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml .

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India Harsh panchal

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command and arguments have been used, and which report that command shown.

  • Assigned to nitin_lama
  • Comment over 1 year ago →
    🇮🇳India nitin_lama India
  • Issue was unassigned.
  • Comment over 1 year ago →
    🇮🇳India nitin_lama India
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Status changed to Needs work 7 months ago
  • Comment 7 months ago →
    🇵🇭Philippines cleavinjosh

    Hi,

    I applied patch #18 and it was applied smoothly. However, I still encountered some issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.

    ➜  drupal_libcal git:(1.x) curl https://www.drupal.org/files/issues/2022-10-17/phpcs-drupal-coding-standard-issue-3304730-18.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 52475  100 52475    0     0   108k      0 --:--:-- --:--:-- --:--:--  108k
patching file README.md
patching file config/optional/field.field.node.event.field_libcal_url.yml
patching file config/optional/field.storage.node.field_end_date.yml
patching file config/optional/field.storage.node.field_libcal_url.yml
patching file css/event-page.css
patching file libcal.libraries.yml
patching file libcal.module
patching file libcal.services.yml
patching file src/EventDownloadService.php
patching file src/EventDownloadServiceInterface.php
patching file src/Form/LibcalAPIConfigForm.php
➜  drupal_libcal git:(1.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml drupal_libcal

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/drupal_libcal/src/Form/LibcalAPIConfigForm.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 45 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/drupal_libcal/src/EventDownloadService.php
------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\node\Entity\Node.
 64 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------

Time: 314ms; Memory: 12MB

➜  contrib git:(main) ✗

    Thank you.

  • Status changed to Needs review 7 months ago
  • Comment 7 months ago →
    🇵🇭Philippines cleavinjosh

    I provided a patch for the issues I found. Kindly review.

    Thank you.

  • First commit to issue fork.
  • Merge request !2fixed phpcs issues → (Open) created by Unnamed author
  • Merge request !3Issue #3304730: Fix the issues reported by phpcs → (Open) created by apaderno
  • Pipeline finished with Failed
    7 months ago
    Total: 41s
    #221874
  • Pipeline finished with Failed
    7 months ago
    Total: 629s
    #221866
  • Pipeline finished with Failed
    6 months ago
    Total: 43s
    #227431
  • Status changed to Needs work 5 months ago
  • Comment 5 months ago →
    🇮🇳India Tirupati_Singh

    Hi @cleavinjosh, I've applied the MR !3 as a patch and it applied cleanly with no errors. After applying patch the mentioned PHPCS issue has been resolved successfully. Ran command phpcs --standard=“Drupal,DrupalPractice” --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml . to check the phpcs issues. The MR !3 has resolved the phpcs issues but while visiting the module configuration page /admin/config/libcal getting below errors. I've attached all the before and after screenshots for your reference.

    The website encountered an unexpected error. Try again later.

ArgumentCountError: Too few arguments to function Drupal\libcal\EventDownloadService::__construct(), 0 passed in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 3 expected in Drupal\libcal\EventDownloadService->__construct() (line 61 of modules/custom/drupal_libcal/src/EventDownloadService.php).

    @atul_ghate, I've also tried applying the MR !2 as a patch but it is not being applied. Getting errors while applying the patch mentioned in the attached screenshot. And also the MR has been raised against the wrong target branch. The MR will be raised against the 1.x branch instead of main branch.

    As both the MRs are not resolving the issue at all, moving the issue status to Needs work. I've attached all the screenshots for reference.

  • Comment 5 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    Unfortunately, GitLab CI does not help in this case, since even the composer pipeline fails.

  • Status changed to Needs review 5 months ago
  • Comment 5 months ago →
    🇮🇳India atul_ghate

    Hi @tirupati_singh, MR2 is getting applied cleany and resolved all phpcs issue.(see attached screenshot)

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024