Drupal 10 Compatibility

When I apply #7 patch.
Patch apply cleanly I attached some screenshot also.
It can be moved to RTBC.

Thanks

Charchil Khandelwal → made their first commit to this issue’s fork.

Please set this as a release. I cannot update to D10 with patches.

Please, make a release.

Patch #7 works great with D10. Please proceed to RTBC

Confirmed the patch in #7 works for me as well. Changing to RTBC.

I can also confirm patch in #7 works and I have this running on 25 production sites for well over a month and everything works as expected.

Patch #7 is working as expected.

When I install patch 7, using
"patches": {

    "enable-patching": true,
     "drupal/superfish": {
           "rector patch": "https://www.drupal.org/files/issues/2023-01-18/3299991-drupal-10-compatibility-fixes-7.patch"
      }
},
"drupal-lenient": {
"allowed-list": ["drupal/superfish"]
}

I get

drush updb
 [preflight] Mapping values are not allowed in multi-line blocks at line 2 (near "<?php").

Lots of internal modules are upgraded/downgraded doing this.

Dear developers,

Please, put a release of Superfish for Drupal 10 in the repository.

I've patched my Drupal 9 version successfully with path 3299991 ( So, the Upgrade_Status is fine.), however it fails to update to Drupal version 10 since it can not be found in the repository of Drupal. Using composer update....dev-x.1.

Or is there another way to upgrade Superfish to Drupal 10.

Kind regards,

Marcel

Save a tar file of the patched module, and also one of the library as that is a dependency. Ten do a composer remove without uninstalling superfish. Then untar the files to put all the files back. That makes it all work again whilst composer knows nothing about so can try the update to drupal 10. Once the d10 version of superfish is finally released then install it via composer. That is how we've got round it.

The alterations are operating smoothly on Drupal 10.1.x version and have achieved compatibility.
It would be greatly appreciated if the module maintainers could create a release for Drupal 10 of this module, as it is widely used on many websites and will be advantageous during the upgrade process from Drupal 8 or 9 to 10.

Thank you.

For those, who have problems with composer, because info file cannot be patched, you can use this configuration:

    "config": {
        "preferred-install": {
            "drupal/superfish": "source",
            "*": "auto"
        }
    },

There is a standard solution to add a module that does not have a D10 compatible release in D10 and that's the new Composer Drupal Lenient plugin. With this you can install the module and then patch it to become compatible.

@chike We appreciate you informing us about this tool.

+1 to RTBC
I tested the patch #7 on Drupal 10.0.8. Everything looks fine and works without any errors.
Would be great to have D10 release

I too would be extremely grateful for an official D10-compatible release

I tried to contact the maintainer, he has never replied. I believe the only way to get a new release to take over the maintenance

As for me #7 patch is not working and it was not applied.

@LOBsTerr You are correct, the author of the module has not been active since 2020. It would be beneficial if they designated someone else as maintainers to ensure that this excellent module receives proper upkeep. I will attempt to contact the author via their contact page and hope to receive a response.

I tested it on Drupal 10 - it is workes well
superfish-d10-compatibility-15053339-9.patch

I will try to take it over.

If i use the patched Version fo superfish with core_version_requirement: ^8 || ^9 || ^10 in the info-file and the other changes, i get the message from composer:
drupal/superfish dev-1.x requires drupal/core ^8 || ^9 -> found drupal/core[8.0.0, ..., 8.9.20, 9.0.0, ..., 9.5.9] but it conflicts with your root composer.json require (^10.0).

How to get the patched version under composer controll in Drupal 10?

@Lissy you can use Drupal's Lenient Composer Endpoint → to avoid composer version compatibility issues.

@snap_x thank you for your suggestion, I successfully installed the module on my drupal 10 instance using the Drupal' Lenient and I applied the patch #32

Patch #32 is working for me.

I have successfully tested patch #32 on the Drupal 10 dev after installing the module and applying the Drupal Lenient plugin.

The patch in 32 does not apply with lenient to 8.x-1.x-dev. The patch in 7 does apply with lenient.

@drupgirl Can you please share your composer.json

@LOBsTerr any luck becoming a maintainer of this project? I think at this point all we need is a stable release.

Sorry guys, I was a bit busy these days.
I have to follow a procedure. First I have created a ticket #3369119: Project maintenance → and if there is not response I can ask to transfer the ownership. We will have to wait a bit more

It's my second last module with incompatibility warning in upgrade status.
I would be extremely grateful for a D10-compatible release.
I'm not familiar with patching.
Thanks

I would be grateful too!
It is used in soo many sites...

Also i would be very happy about a D10-compatible release!

LOBsTerr → credited Vishal Choudhary → .

Thank you everyone for contribution

I want to thank everyone who worked to get this D10 version to release. Best thing to wake up to today!

Hooray! Thank you @LOBsTerr for your persistence in getting a release out!

Yippiee!!! Thanks from me. ;-)

Hi, just great, your work
It works

Automatically closed - issue fixed for 2 weeks with no activity.