...and the correct patch is this (sorry for that mess)
Based on Jons comment #2, I created a patch. I think that the code needs a small fix so I've done it, too.
if (!empty($plugin_definition)) {
$this->provider = $this->pluginDefinition['provider'];
}
if (!empty($configuration)) {
$this->setConfiguration($configuration);
}Patch #7 works great with D10. Please proceed to RTBC
patch#8 works great at D10. I think it can proceed to RTBC
It's working in latest D10. Please proceed with a release.
Please commit the latest changes. It seems ready for D10.
As first step in order to test it as @bnjmnm propose is to create a simple patch to change into ckeditor5_stylesheets and then get ready for manual tests
After two years from the latest post, there is a new module in play,
Drupal Symfony Mailer →
, which replaces the whole Drupal mailing system and the module mailsystem, is used as a replace of Swift Mailer.
So the
https://www.drupal.org/project/mailsystem/issues/3166149 →
is not applicable any more. But the issue that @introfini explains, especially in #2 is crucial.
Should be opened a new issue based on newly module Drupal Symfony Mailer and start the conversation from scratch?
I am interested in this issue too.
Regardless of the tests, the patch #45 is working in Drupal Core 9.5.3. I have tested with Commerce 2, using product variations with image linked to content.
This doesn't work, at least with commerce.
I found out that due to this issue https://www.drupal.org/project/drupal/issues/2930736 🐛 EntityViewsData assumes BaseFieldDefinitions where it should use FieldDefinitionInterface Needs work if change the variable $field_definition --> $field_storage_definition, it works.
Hi,
I tried the last patch #34 but it has no impact with tables commerce_product_field_data and commerce_product_variation_field data. The join query has only the product_id but no langcode is present