- πΊπΈUnited States smustgrave
So bootstrap layout builder has instances of once too that will need to be replaced to test this.
Think this could be a critical almost as currently bootstrap layout builder does not work in Drupal 10
- π΅π±Poland prauat Wroclaw
@smustgrave Can you tick this as reviewed?
- Status changed to RTBC
almost 2 years ago 11:16pm 25 January 2023 - πΊπΈUnited States smustgrave
Tested as part of the fix for layout builder and this resolves the deprecated once() calls
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:59pm 7 March 2023 - π§πͺBelgium jmaerckaert Geer, province of LiΓ¨ge
Reroll for the version 1.1.0.
- π¬π·Greece perarg
patch#8 works great at D10. I think it can proceed to RTBC
- Assigned to Sonam goswami52
- Issue was unassigned.
Patch #8 applied successfully on drupal 10 and its working fine for me.
Thank you- Status changed to RTBC
almost 2 years ago 12:44pm 14 March 2023 - πΊπ¦Ukraine david-b Kropyvnytskyi
Patch #8 working good for me. All errors with "once" are fixed.
- πΊπΈUnited States dalemoore
I can't get any of these patches for Bootstrap Styles and Bootstrap Layout Builder to apply in Drupal 10 and the module is just broken. Have they been tested with D10 10.0.9?
- π΅π±Poland prauat Wroclaw
Hi @dalemoore against which version you've been trying to apply patch?
- πΊπΈUnited States dalemoore
Hi @prauat, I'm on D10.0.9 and Bootstrap Styles 1.1.0 and Bootstrap Layout Builder 2.1.1. The issue is highly likely to be PEBKAC, but I can't figure out what the issue is. Having the "Fix not loading bootstrap_styles/aos.local or bootstrap_styles/aos.remote library" along with "[Drupal 10] Change of JS jquery/once to drupal core/once, migrate JS API." and "Fix Module does not work in D10" issues, at the least.
In my composer.json:
"patches": { "drupal/bootstrap_styles": { "3315218: Fix not loading bootstrap_styles/aos.local or bootstrap_styles/aos.remote library.": "https://www.drupal.org/files/issues/2023-01-25/3315218-17--1-0-x.patch", "3330458: [Drupal 10] Change of JS jquery/once to drupal core/once, migrate JS API.": "https://www.drupal.org/files/issues/2023-03-07/bootstrap_styles-3330458-8.patch" }, "drupal/bootstrap_layout_builder": { "3335356: Fix Module does not work in D10": "https://www.drupal.org/files/issues/2023-01-25/issue_3335356_drupal10.patch" } },
-
Rajab Natshah β
committed 60219f68 on 1.0.x authored by
jmaerckaert β
Issue #3330458 by prauat, jmaerckaert: [Drupal 10] Change of JS jquery/...
-
Rajab Natshah β
committed 60219f68 on 1.0.x authored by
jmaerckaert β
-
Rajab Natshah β
committed ba29fd77 on 2.0.x authored by
prauat β
Issue #3330458 by prauat, jmaerckaert: [Drupal 10] Change of JS jquery/...
-
Rajab Natshah β
committed ba29fd77 on 2.0.x authored by
prauat β
- Status changed to Fixed
over 1 year ago 9:45am 27 July 2023 - π―π΄Jordan Rajab Natshah Jordan
β Released bootstrap_styles-1.1.1 β
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 5:48pm 16 August 2023