Expiration to 0 doesn't create session cookie

Thanks for the report. I'd also expect "0" (session duration) to work. We should add a test for that.

@Grevil will have a look asap and if there are any questions, contact me.
In the meantime, anyone may provide a MR or details to speed things up.

Wow, that is really weird...

It even says in the description, "Set to 0 to expire with browser close."
Seems this feature broke at some point, and we simply had no test for this...

But yes, I can reproduce this issue.

Probably this is the wrong line: https://git.drupalcode.org/issue/cookies-3343952/-/blob/3343952-expirati...

Guess the empty check is incorrect.

An cookie expiration of 0 (session duration) should be fine. But please test carefully.

Fixed! Works perfectly fine now!

Please review!

Great work!! :)

Automatically closed - issue fixed for 2 weeks with no activity.