- Assigned to Sarika Wirtz
- Status changed to Needs work
almost 2 years ago 12:26pm 27 January 2023 - π©πͺGermany Sarika Wirtz
Installed and enabled module. Applied patch. Allowed field to accept "SVG" image but did not work for me. after uploading sgv image got an error(
svg-error.png)In log error: Entity view display 'node.article.default': Component 'comment' was disabled because its settings depend on removed dependencies.
- Issue was unassigned.
- π³π±Netherlands Martijn de Wit π³π± The Netherlands
@Sarika Wirtz can you post also your image field widget settings form?
Did you install and test it on a clean D10 installation ? - πΈπ°Slovakia poker10
I tried to repeat the steps from #27, but cannot reproduce the problem.
Clean D10 installation, installed and enabled this module with the patch applied. Allowed field to accept the "SVG" format. Created new node and uploaded SVG image without any problems. The node detail page is displayed correctly with the SVG image.
Also I suppose we should leave the tags here just in case the bot comes with something new (or the maintainer should decide if/when to remove that tag).
- Status changed to Needs review
almost 2 years ago 1:55pm 27 January 2023 - πΊπΈUnited States danflanagan8 St. Louis, US
This should be at NR. The errors in #27 appear unrelated to this module and it should not have been kicked back to NW. It would be great if someone who has tested (@poker10?) would RTBC this.
- Assigned to Sarika Wirtz
- π©πͺGermany Sarika Wirtz
As @Martijn de Wit said. I installed fresh installation of Drupal10.
- Status changed to RTBC
almost 2 years ago 2:29pm 27 January 2023 - π©πͺGermany Sarika Wirtz
As @Martijn de Wit said. I installed fresh installation of Drupal10. Installed module. Applied patch and I must say it's working perfectly fine. I can not reproduce my own error anymore. moving to RTBC.
- π©πͺGermany Sarika Wirtz
@poker10 By mistake i removed your tag. Added them again. My apologies.
- @grevil opened merge request.
- First commit to issue fork.
- @grevil opened merge request.
- π©πͺGermany Grevil
RTBC +1. Couldn't find any missing deprecation errors, using the upgrade_status module and PHPStan. Installs successfully under Drupal 10.
I closed MR 13 for visibility's sake (since it was on the wrong issue fork branch). Removed patch #12 from "3299276-automated-drupal-10", applied patch #23 by @daniel_j to branch "3299276-automated-drupal-10" and opened an MR for easier review!
- Issue was unassigned.
- π©πͺGermany Anybody Porta Westfalica
Thank you for this review and cleanup @Grevil! Also confirming RTBC! :)
Maintainers?
- ππΊHungary nagy.balint
I sent a mail through contact form to the maintainer.
- π¦π²Armenia le72 Yerevan π¦π²
This is the one of few modules which prevent our upgraded to D10!
Please add a new version. - Assigned to imyaro
Checking patch, will do a release soon.
Thanks everyone for participating-
imyaro β
committed abcd2997 on 8.x-1.x authored by
Grevil β
Issue #3299276: Automated Drupal 10 compatibility fixes
-
imyaro β
committed abcd2997 on 8.x-1.x authored by
Grevil β
- Status changed to Fixed
almost 2 years ago 11:41am 13 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.