- @gauravvv opened merge request.
- Status changed to Needs review
over 1 year ago 8:35am 23 February 2023 - Status changed to Needs work
over 1 year ago 3:44pm 24 February 2023 - ๐บ๐ธUnited States smustgrave
Not sure if #10.2 has been addressed either.
Will need screenshots since .css file changed.
- Status changed to Needs review
over 1 year ago 4:55am 27 February 2023 - ๐ฎ๐ณIndia gauravvvv Delhi, India
I have added before/after patch screenshots for reference:
Before patch
After patch
- Status changed to RTBC
over 1 year ago 2:32pm 28 February 2023 - ๐บ๐ธUnited States smustgrave
Only nit picky maybe could be
.layout-region--node-footer .layout-region__content
but don't think that will hold up the issue. - Status changed to Needs work
over 1 year ago 8:08am 3 March 2023 - ๐ซ๐ฎFinland lauriii Finland
Unfortunately, this introduces some regressions with RTL.
Before:
After:
Gaurav-drupal โ made their first commit to this issueโs fork.
- Status changed to Needs review
over 1 year ago 11:00am 3 March 2023 - Status changed to RTBC
over 1 year ago 4:21pm 3 March 2023 - ๐บ๐ธUnited States smustgrave
Confirmed the issue on #25 has been addressed.
- Status changed to Needs work
over 1 year ago 8:39am 4 March 2023 - Status changed to Needs review
over 1 year ago 3:32pm 4 March 2023 - ๐บ๐ธUnited States mherchel Gainesville, FL, US
Uploading this as a patch, since it's a radical departure from the MR above.
IMO, this CSS could be radically simplified.
Because there's multiple rows, it's much easier to use grid than flex
Both grid and flex have built in RTL support, we should make use of that using the gap propertyI ended up refactoring this down to 32 lines of CSS (from 80 in the MR) and IMHO is easier to understand. PCSS is below (for better readability) and patch is attached.
/** * Layout overrides for node add/edit form. */ .layout-region { box-sizing: border-box; } .layout-region--node-footer .layout-region__content { margin-top: var(--space-l); } /** * Move to two column layout at wider widths. */ @media (min-width: 61rem) { .layout-node-form { display: grid; grid-template-columns: 3fr minmax(360px, 1fr); gap: var(--space-l); } .layout-region--node-main, .layout-region--node-footer { margin-inline: auto; width: min(832px, 100%); } /* Push sidebar down to horizontal align with form section. */ .layout-region--node-secondary { margin-block-start: var(--space-l); } }
- Status changed to Fixed
over 1 year ago 8:14am 19 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.