- First commit to issue fork.
- 🇳🇱Netherlands ekes
Added some additional fixes need for Drupal 10. Tests still don't pass in
3287037-automated-drupal-10
because of 🐛 Warning: Undefined array key "pathauto" in Drupal\domain_path_pathauto\DomainPathautoHelper Needs review . Thedrupal-10-plus-patches
branch includes fixes from the queue that we're using (in D9) and does pass tests (in D10). - Status changed to Needs work
over 1 year ago 8:50pm 3 May 2023 - 🇺🇦Ukraine i-trokhanenko Lutsk 🇺🇦
the MR #13 contains merge conflicts, could you please update the MR with a 8.x branch of the module?
- First commit to issue fork.
- @shivam_tiwari opened merge request.
- Status changed to Needs review
over 1 year ago 12:54pm 4 May 2023 - Status changed to Needs work
over 1 year ago 2:31pm 26 May 2023 - 🇺🇸United States mradcliffe USA
I set the status to "Needs work" as both open merge requests have merge conflicts. I took a look at this a couple of weeks ago and the merge conflicts are significant compared to the current state of 8.x-1.x-dev branch. It may be better to review the Drupal 10 compatibility fixes from a clean branch rather than trying to do a merge to resolve conflicts.
- Status changed to Needs review
over 1 year ago 3:32pm 26 May 2023 - 🇺🇸United States mradcliffe USA
After reviewing the commits, I've found the following for 3287037-automated-drupal-10, and did a local rebase per GitLab and force pushed the result being only applying the 2 commits and dropping the rest.
- * 56f6ecec59c95842606a3251e7d82e86faa15a57 (outdated) Fixed by @ekes in 🐛 Existing Tests fail Fixed
- * 54149b7258f7e68007383f1b78e0f973227e2e3e (outdated) Fixed by @quadrexdev, @Yaroslav Kozak in #3300654: Node edit form keeps toggle on when custom path is provided →
- * 65b1639be603119fb31340050f15fa82f6874c42 (outdated) Fixed by @Yaroslav Kozak in #3306549: Cannot use object of type Drupal\Core\StringTranslation\TranslatableMarkup as array in Drupal\domain_path\DomainPathHelper::validateEntityForm() →
- * f7bfa3e7f3dab2bab1990145bbcdb46cded58c39 (outdated) Fixed by @ekes in 🐛 Existing Tests fail Fixed
- * 2e25f7bca58613cf49e32c34b75c1039b5fa2b36 Relevant
- * 39a6635d41de62f86c2597170e3ba4f04df3bf53 Relevant
- * b30085a39a143bf63ad0334059a1321dfd6928db (outdated) Fixed by @ekes in 🐛 Existing Tests fail Fixed
Additionally, ekes' fixes in drupal-10-plus-patches can probably be rebased using the following:
- * #3287037
- * #3300654: Node edit form keeps toggle on when custom path is provided → -- outdated
- * #3306549: Cannot use object of type Drupal\Core\StringTranslation\TranslatableMarkup as array in Drupal\domain_path\DomainPathHelper::validateEntityForm() → -- outdated
- * 🐛 Warning: Undefined array key "pathauto" in Drupal\domain_path_pathauto\DomainPathautoHelper Needs review
- * 🐛 Error manually adding an alias when Domain Path Pathauto is enabled Fixed -- outdated
- * 🐛 domain_path_pathauto creates duplicate aliases Active
I recommend using Merge Request !13, and then following up on the open issues in @ekes' drupal-10-plus-patches listed above.
- Status changed to Closed: outdated
over 1 year ago 6:58pm 22 June 2023 - 🇺🇸United States agentrickard Georgia (US)
I am closing this for 8.x. Looks like we need a new issue for 2.x
- Status changed to Needs review
over 1 year ago 6:59pm 22 June 2023 - Assigned to kushagra.goyal
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 12:26pm 23 June 2023 MR !13 is applying correctly. no other issues not observed as it is working as expected. module is compatible with D10 Hence moving to RTBC. screenshot Attached..
-
i-trokhanenko →
committed b253aff8 on 8.x-1.x authored by
quadrexdev →
Issue #3287037 by Project Update Bot, mradcliffe, ekes, quadrexdev, i-...
-
i-trokhanenko →
committed b253aff8 on 8.x-1.x authored by
quadrexdev →
- Status changed to Fixed
over 1 year ago 7:19pm 23 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.