- Status changed to Needs work
almost 2 years ago 2:06am 17 January 2023 - @quietone opened merge request.
- Status changed to Needs review
almost 2 years ago 1:41am 23 January 2023 - 🇳🇿New Zealand quietone
Converted to an MR as suggested in #10.
The MR has fixes for all the points listed in the review in #9. Item 16 and 17 are not done because core/modules/pgsql/src/Driver/Database/pgsql/Schema.php was deprecated.
- Status changed to RTBC
almost 2 years ago 4:25pm 23 January 2023 - 🇺🇸United States smustgrave
Tested this out by commenting out the phpcs line and running against changes in the MR.
They all passed locally with that rule disabled.
- Status changed to Needs work
almost 2 years ago 4:29am 24 January 2023 - 🇺🇸United States xjm
Got further this time, all the way into views. Boy is a lot of this change set in Views...
Again, if you could, please extrapolate and make note of where other docs standards (like the sentence structure and grammar) are not being followed.
- Status changed to Needs review
almost 2 years ago 10:04am 28 January 2023 - 🇺🇸United States smustgrave
Changes look good.
Do we need a follow up for EntityFormInterface?
- Status changed to RTBC
almost 2 years ago 11:59pm 6 February 2023 - 🇺🇸United States smustgrave
Opened up 📌 Update archaic standard in comments. Active for the follow up. Wasn't entirely sure what the grep command was though.
- Status changed to Needs work
almost 2 years ago 2:56pm 17 March 2023 - 🇬🇧United Kingdom catch
Some of the views plugin descriptions are still not readable to me at all, similar to feedback in #9.
- Status changed to Needs review
almost 2 years ago 9:00pm 29 March 2023 - Status changed to RTBC
almost 2 years ago 7:25pm 1 April 2023 - 🇺🇸United States smustgrave
These are not my best will fully admit.
But I took a look at MR 3275 and the changes make sense to me.
- last update
over 1 year ago 29,202 pass - last update
over 1 year ago 29,207 pass - last update
over 1 year ago 29,283 pass - last update
over 1 year ago 29,300 pass - last update
over 1 year ago 29,302 pass - last update
over 1 year ago 29,300 pass - last update
over 1 year ago 29,359 pass 9:14 6:01 Running-
longwave →
committed cabb82dd on 10.0.x
Issue #3268835 by quietone, smustgrave, ravi.shankar, xjm, borisson_,...
-
longwave →
committed cabb82dd on 10.0.x
-
longwave →
committed b212d244 on 10.1.x
Issue #3268835 by quietone, smustgrave, ravi.shankar, xjm, borisson_,...
-
longwave →
committed b212d244 on 10.1.x
-
longwave →
committed 0ad211a5 on 9.5.x
Issue #3268835 by quietone, smustgrave, ravi.shankar, xjm, borisson_,...
-
longwave →
committed 0ad211a5 on 9.5.x
- 🇬🇧United Kingdom longwave UK
Committed and pushed to 10.1.x, 10.0.x and 9.5.x. Thanks!
The MR did not apply to 9.5.x in core/lib/Drupal/Core/Routing/Router.php but I skipped that change there because in 9.5.x the docblock was already just @inheritdoc.
- Status changed to Fixed
over 1 year ago 11:29am 18 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.