Enable 'Drupal.Commenting.DocComment.ShortSingleLine' coding standard

The sibling issues both landed so we can enable the sniff and fix any stragglers here.

Ah, you beat me to changing the status!

It looks it was decided to fix the class properties as well in this last issue. That was only 12 files and the patch is small, so that is reasonable.

A few nits:

1. +++ b/core/modules/editor/tests/src/Functional/Update/EditorAddLazyLoadImageFilterUpdateTest.php
   @@ -7,8 +7,7 @@
   + * Tests update of editor_file_reference with editor_image_lazy_load filter.
   

   This is difficult because of the length of the snake_case_words but "Tests adding editor_image_lazy_load filter to editor_file_reference." is a bit clearer?

2. +++ b/core/modules/field/tests/src/Kernel/EntityReference/EntityReferenceFormatterTest.php
   @@ -54,8 +54,7 @@ class EntityReferenceFormatterTest extends EntityKernelTestBase {
   +   * An entity that in not yet saved to its persistent storage.
   

   in -> is

3. +++ b/core/modules/migrate/src/Plugin/Migration.php
   @@ -205,8 +205,7 @@ class Migration extends PluginBase implements MigrationInterface, RequirementsIn
   +   * The source_row_status for current map row.
   

   "The source_row_status for the current map row."

4. +++ b/core/modules/rest/tests/src/Functional/EntityResource/EntityResourceTestBase.php
   @@ -87,16 +87,18 @@ abstract class EntityResourceTestBase extends ResourceTestBase {
   +   * A list of field that need a unique value.
   

   field -> fields

@longwave, thanks for the review.

All comment changes look good to me.
The PHPCS rule has been enabled in the patch.
For me it is RTBC.

@daffie, thank you.

Adding patches for 9.5.x and 10.0.x.

We can only enable the sniff in a minor release, so I committed the change to phpcs.xml.dist to 10.1.x only and skipped it for the other branches.

Committed and pushed to 10.1.x, 10.0.x and 9.5.x. Thanks!

Whoops, committed 10.0.x and 9.5.x with the wrong commit message - reverted and re-committed with the right message.

Whoops, this is breaking testing on the 9.5.x branch right now. E.g. see https://www.drupal.org/pift-ci-job/2657088 → (from 📌 Fork laminas/laminas-diactoros Fixed ):

There was 1 failure:

1) Drupal\Tests\Core\Theme\ClassyPreprocessUnchangedTest::testNoNewPreprocess
The file hash for classy.theme has changed. Any additions or changes to preprocess functions should be added to the themes that inherit Classy. 
If the changes to classy.theme are not changes to preprocess functions, update the hash in this test to: '1a5f162bc900c45957aaa89959bcb607' so it will pass.
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'1a5f162bc900c45957aaa89959bcb607'
+'c42ff3a1291a258b42f0c44010cd28c7'

Since this patch touched classy.theme on the 9.5.x branch, we need to update core/tests/Drupal/Tests/Core/Theme/ClassyPreprocessUnchangedTest.php to match.

Not sure if this should be reverted and re-re-committed, or if we just want a hot-fix. Should the hot-fix be here or a separate issue?

Thanks!
-Derek

p.s. Oh wow, the 9.5.x test failed the same way above. See https://www.drupal.org/pift-ci-job/2655998 → ...

Here's the hotfix for the current 9.5.x branch. Not sure if it should go here or a follow-up, but making it easier for whomever wants to move this forward.

Thanks!
-Derek

p.s. I swapped the order of the hash and the $hash since assertSame() wants the expected value first. The failure output was confusing.

Looks good to me.

My bad, I thought it was a random fail and didn't check properly. Pushed #75 as a hotfix to 9.5.x, many thanks for spotting and fixing this!

@dww and longwave, Thank you! I should have come back and checked on this.

quietone → closed merge request !1886

quietone → closed merge request !500

Automatically closed - issue fixed for 2 weeks with no activity.