Node view breaks when the underlying book node is missing

The website encountered an unexpected error. Please try again later. Error: Call to a member function access() on null in book_node_view() (line 233 of core/modules/book/book.module). book_node_view(Array, Object, Object, 'full') call_user_func_array('book_node_view', Array) (Line: 403) Drupal\Core\Extension\ModuleHandler->invokeAll('node_view', Array) (Line: 288) Drupal\Core\Entity\EntityViewBuilder->buildMultiple(Array) (Line: 239) Drupal\Core\Entity\EntityViewBuilder->build(Array) call_user_func_array(Array, Array) (Line: 101) Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 786) Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 377) Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 201) Drupal\Core\Render\Renderer->render(Array, ) (Line: 241) Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 578) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 242) Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 91) Drupal\next\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 132) Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90) Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object) call_user_func(Array, Object, 'kernel.view', Object) (Line: 142) Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 163) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 67) Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle(Object, 1, 1) (Line: 57) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 49) Asm89\Stack\Cors->handle(Object, 1, 1) (Line: 47) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23) Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 717) Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 2 years ago →
🇨🇦Canada joseph.olstad
I just hit this, patch works great thanks! :)

Without the patch, get a WSOD with an exception as described above for certain books as described in the issue summary.

This would be a great fix to get into core. It would probably be not too hard to write a test for this case.
Status changed to Needs review almost 2 years ago12:23pm 15 May 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,372 pass, 2 fail
Comment almost 2 years ago →
🇮🇳India ranjith_kumar_k_u Kerala
Added test to show the issue, please review
Comment almost 2 years ago →
System Message
The last submitted patch, 7: 3260888-7-test-only.patch, failed testing. View results →

Comment almost 2 years ago →

🇫🇷France andypost

+++ b/core/modules/book/tests/src/Functional/BookTest.php
@@ -461,6 +461,14 @@ public function testBookDelete() {
+    $this->assertSession()->responseNotContains('The website encountered an unexpected error. Please try again later');
+    $this->assertSession()->statusCodeEquals(200);

Better to check for what was rendered instead of missing error message which may change in future

Status changed to Needs work almost 2 years ago10:58pm 29 May 2023

Comment almost 2 years ago →

🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

I think we can probably do $node?->access() now too

+++ b/core/modules/book/tests/src/Functional/BookTest.php
@@ -461,6 +461,14 @@ public function testBookDelete() {
+    // Set the child page book id to deleted book id, and visit the child page.
+    $node = $node_storage->load($nodes[0]->id());
+    $node->book['bid'] = $nodes[0]->book['bid'];
+    $node->save();

this feels kind of artificial

do we have any details of how this bug can be encountered by correct use of APIs?

+++ b/core/modules/book/tests/src/Functional/BookTest.php
@@ -461,6 +461,14 @@ public function testBookDelete() {
+    $this->assertSession()->responseNotContains('The website encountered an unexpected error. Please try again later');

Let's remove this

+++ b/core/modules/book/tests/src/Functional/BookTest.php
@@ -461,6 +461,14 @@ public function testBookDelete() {
+    $this->assertSession()->statusCodeEquals(200);

Let's also add a positive assert for e.g. the node title or something (edit: what andypost said)

Status changed to Needs review almost 2 years ago11:27am 31 May 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
29,402 pass
Comment almost 2 years ago →
🇮🇳India ranjith_kumar_k_u Kerala
Addressed #11, I didn't make any changes on 11.1.

this feels kind of artificial
do we have any details of how this bug can be encountered by correct use of APIs?

We can't reproduce this bug by using correct node deletion methods (programmatically($node->delete()) or deleting the node through the interface), I'm not sure about the migration part
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
29,400 pass
Status changed to Needs work almost 2 years ago1:14pm 31 May 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
Maybe we need a migration test? But think the tests should reflect what’s possible through the API
Comment about 1 year ago →
🇳🇿New Zealand quietone
Comment 8 months ago →
🇺🇸United States smustgrave
Still will need tests
Merge request !37Issue #3260888 by ranjith_kumar_k_u, LaravZ: Node view breaks when the... → (Merged) created by smustgrave

Comment 7 months ago →

System Message

smustgrave → committed 4daf2263 on 2.0.x

Issue #3260888 by ranjith_kumar_k_u, LaravZ: Node view breaks when the...

Comment 7 months ago →
🇺🇸United States smustgrave
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Node view breaks when the underlying book node is missing

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!37Node view breaks when the underlying book node is missing
Merged

Comments & Activities

Node view breaks when the underlying book node is missing

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!37Node view breaks when the underlying book node is missingMerged

Comments & Activities

!37Node view breaks when the underlying book node is missing
Merged