- last update
over 1 year ago Patch Failed to Apply - 🇳🇱Netherlands arantxio Dordrecht
Here is a start for this change. I removed some function that was designed for D8 and then mapped and adjusted all the functions that referred to Drupal\Driver. Some might be removable, but we have to decided on that because its also kind off test coverage.
- last update
over 1 year ago 29,797 pass - 🇳🇱Netherlands arantxio Dordrecht
Setting the version to D11 because 10.2 doesn't exist yet, we'll need to adjust this when the it's added.
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - 🇺🇸United States smustgrave
10.2 will just be a tag off 11.x so as long as it works there it should be good.
Requeuing tests to make sure mysql and sqllite passes.
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 29,797 pass - last update
over 1 year ago 29,797 pass - Status changed to RTBC
over 1 year ago 2:55pm 5 July 2023 - 🇺🇸United States smustgrave
Refactor didn't seem to cause a regression. Think it would be good to get this in early for 10.2
- 🇬🇧United Kingdom catch
This could have gone in prior to 10.0.0 but I think it will need to wait until (actual) 11.x now.
- Status changed to Needs review
over 1 year ago 2:20pm 6 July 2023 - Status changed to Postponed
over 1 year ago 2:28pm 7 July 2023 - 🇺🇸United States smustgrave
Seems like postponed makes sense then.
Is Major version only how you find D11 tickets or is there another tag?
- Status changed to Needs work
9 months ago 9:07am 19 March 2024 - 🇮🇹Italy mondrake 🇮🇹
This is actionable now. Needs rebase and change to MR workflow.
- 🇳🇱Netherlands arantxio Dordrecht
I've added most of the patch to a merge request, however some of the code has changed already and some classes are gone.
I don't see any more tests that reference Drupal\Driver or Drupal\\Driver. But a check on it would be great.
I couldn't run the tests locally so I hope someone else could go through it.
- 🇫🇷France andypost
As I see only 4 usages left
$ git grep database_drivers core/tests/Drupal/KernelTests/Core/Database/SelectExtenderTest.php:122: $additional_class_loader->addPsr4("Drupal\\core_fake\\Driver\\Database\\coreFake\\", __DIR__ . "/../../../../../tests/fixtures/database_drivers/module/core_fake/src/Driver/Database/CoreFake"); core/tests/Drupal/KernelTests/Core/Database/SelectExtenderTest.php:123: $additional_class_loader->addPsr4("Drupal\\core_fake\\Driver\\Database\\CoreFakeWithAllCustomClasses\\", __DIR__ . "/../../../../../tests/fixtures/database_drivers/module/core_fake/src/Driver/Database/CoreFakeWithAllCustomClasses"); core/tests/Drupal/Tests/Core/Database/ConnectionTest.php:324: $additional_class_loader->addPsr4("Drupal\\core_fake\\Driver\\Database\\CoreFake\\", __DIR__ . "/../../../../../tests/fixtures/database_drivers/module/core_fake/src/Driver/Database/CoreFake"); core/tests/Drupal/Tests/Core/Database/ConnectionTest.php:325: $additional_class_loader->addPsr4("Drupal\\core_fake\\Driver\\Database\\CoreFakeWithAllCustomClasses\\", __DIR__ . "/../../../../../tests/fixtures/database_drivers/module/core_fake/src/Driver/Database/CoreFakeWithAllCustomClasses");
- 🇳🇿New Zealand quietone
I wasn't sure about this issue so I confirmed with @daffie that this is still relevant. In the same message they mentioned that there are other higher priority issues than removing these tests.