MigrateSkipRowException should document that it is for use within migration process plugins

Comment over 1 year ago →
🇳🇿New Zealand quietone
I don't know why I didn't move this to the migration system, that is where the migrate maintainers work from.
First commit to issue fork.
Merge request !4150Updated docblock for MigrateSkipRowException class → (Closed) created by _shy
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,436 pass
Status changed to Needs review over 1 year ago2:35pm 9 June 2023
Comment over 1 year ago →
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
Updated docblock for MigrateSkipRowException class.
Status changed to Needs work over 1 year ago9:12pm 9 June 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Left a small comment. Thoughts?
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
39:36
22:00
Running
Comment about 1 year ago →
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
I found a variant from the quietone more descriptive, so I decided to go in this way.
Let's discuss it =)
Status changed to Needs review about 1 year ago3:41pm 25 October 2023
Comment about 1 year ago →
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
Status changed to RTBC about 1 year ago5:35pm 26 October 2023
Comment about 1 year ago →
🇺🇸United States smustgrave
@quietone knows more about the migration system then myself so would go with that suggestion.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,442 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,464 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,483 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,485 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,486 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,488 pass
Comment about 1 year ago →
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
Hi guys!
Do we have some things that still should be done here?
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,511 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
36:09
32:37
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,522 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,551 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,560 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,602 pass
Comment about 1 year ago →
🇺🇸United States mikelutz Michigan, USA
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,605 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,606 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,668 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,675 pass
Comment about 1 year ago →
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
Updated MR.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,684 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,688 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,688 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,688 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,696 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,698 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,712 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,724 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,764 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
Build Successful
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
25,910 pass, 1,802 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
25,905 pass, 1,810 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
25,913 pass, 1,826 fail
Comment about 1 year ago →
🇳🇿New Zealand quietone
I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions or other work to do.

I was considering committing this but it is using my wording for the comment so it will be best for another committer to check this.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
25,914 pass, 1,839 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
25,891 pass, 1,835 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
25,917 pass, 1,835 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
25,907 pass, 1,836 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
25,909 pass, 1,822 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
25,971 pass, 1,831 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
25,969 pass, 1,806 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
25,986 pass, 1,830 fail
Status changed to Fixed 11 months ago6:42pm 3 February 2024
Comment 11 months ago →
🇬🇧United Kingdom longwave UK
Backported as a docs-only fix to 10.2.x.

Committed and pushed e03d3ec549 to 11.x and 290d8a420d to 10.2.x. Thanks!
Comment 11 months ago →
System Message

longwave → committed 290d8a42 on 10.2.x
Issue #3247040 by _shY, quietone, smustgrave, joachim:...
Comment 11 months ago →
System Message

longwave → committed e03d3ec5 on 11.x
Issue #3247040 by _shY, quietone, smustgrave, joachim:...
Comment 11 months ago →
System Message
longwave → closed merge request !4150
Comment 11 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

MigrateSkipRowException should document that it is for use within migration process plugins

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!4150MigrateSkipRowException should document that it is for use within migration process plugins
Closed

Comments & Activities

MigrateSkipRowException should document that it is for use within migration process plugins

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!4150MigrateSkipRowException should document that it is for use within migration process pluginsClosed

Comments & Activities

!4150MigrateSkipRowException should document that it is for use within migration process plugins
Closed