- Merge request !1239Issue #3238868: Refactor (if feasible) uses of the jQuery parents function to use vanillaJS โ (Open) created by hooroomoo
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:53am 1 February 2024 - Status changed to Needs work
over 1 year ago 8:48am 1 February 2024 - ๐ฉ๐ชGermany Feuerwagen Bonn ๐ฉ๐ช๐ช๐บ
I'm pretty sure the issue title doesn't mean โreplace uses of the jQuery parents function with another jQuery functionโ โ these issues are targeted to replace jQuery with vanillaJS.
- ๐ฎ๐ณIndia ahsannazir
Yes got it. I have used closest() with the intention that it works without jquery.
- Status changed to Needs review
over 1 year ago 11:49am 1 February 2024 - ๐ฉ๐ชGermany Feuerwagen Bonn ๐ฉ๐ช๐ช๐บ
Sorry about the noise than and apologies โ I wasn't aware that this method exists in vanillaJs with identical functionality than the one in jQuery.
- Status changed to Needs work
over 1 year ago 12:47pm 2 February 2024 - ๐ฎ๐ณIndia ahsannazir
ahsannazir โ changed the visibility of the branch 11.x to hidden.
- Merge request !6608Issue #3238868: Refactor jquery parents function. โ (Closed) created by Unnamed author
- ๐ฎ๐ณIndia ahsannazir
ahsannazir โ changed the visibility of the branch 3238868-refactor-parents to hidden.
- Status changed to Needs review
over 1 year ago 1:45pm 15 February 2024 - Status changed to Needs work
over 1 year ago 3:22pm 20 February 2024 - ๐บ๐ธUnited States smustgrave
Left some small comments.
Will want sub maintainer sign off before merging.
- Status changed to Needs review
over 1 year ago 9:42am 21 February 2024 - Status changed to Needs work
over 1 year ago 2:51am 1 March 2024 - ๐ซ๐ทFrance nod_ Lille
If we need a 10/20 lines method to replace a jquery call, it's not worth the effort. Let's keep them, and add an eslint ignore.
- ๐ซ๐ทFrance nod_ Lille
Actually we might be able to replicate the parents() functionality with css :has() in some cases:
document.querySelectorAll('*:has(#edit-description)');
would give all the parents of#edit-description
- Status changed to Needs review
over 1 year ago 11:44am 4 March 2024 - ๐บ๐ธUnited States smustgrave
smustgrave โ changed the visibility of the branch 3238868-refactor-if-feasible to hidden.
- Status changed to RTBC
over 1 year ago 10:24pm 4 March 2024 - ๐บ๐ธUnited States smustgrave
Feedback appears to be addressed
@nod_ can we remove the submaintainer tag?
Pushed up a super nitpicky change to remove a space.
- Status changed to Needs work
over 1 year ago 9:20pm 5 March 2024 - ๐ซ๐ทFrance nod_ Lille
There are 4 exceptions and 3 legitimate replacements so let's not call this removing the use of parents.
I'll take the 3 replacements but let's keep the jquery rule as-is and remove the eslint ignore comments
- Status changed to Needs review
over 1 year ago 6:44am 6 March 2024 - Status changed to Needs work
over 1 year ago 10:03am 6 March 2024 - ๐ซ๐ทFrance nod_ Lille
Thanks! a few tiny changes and we should be good to go :)
- ๐ซ๐ทFrance nod_ Lille
I want to see what testbot says about a change in ajax.js
- Status changed to Needs review
over 1 year ago 9:16am 7 March 2024 - Status changed to RTBC
about 1 year ago 3:16pm 22 April 2024 - ๐บ๐ธUnited States smustgrave
Going to lean on @nod_ numerous reviews on this one. Tried to fix an out of scope change for removing a space that's what that commit was.
- ๐ซ๐ทFrance nod_ Lille
Retitle for commit, opened ๐ Refactor (if feasible) uses of the jQuery parents function to use vanillaJS Active to address the other uses of parents and change the eslint config
- Status changed to Fixed
about 1 year ago 9:08pm 22 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- ๐ฏ๐ดJordan Ahmad Khader
This issue appears to break the settings tray, causing contextual links to disappear. please review
https://www.drupal.org/project/drupal/issues/3458067 ๐ Contextual links disappear intermittently leading to console errors Active Unable to find closestSettingsTray;