Spell check all files if dictionary.txt changes

Ran into this with 📌 Remove "Please" from the codebase Fixed . And, if this were done it would reduce the barriers for novices to contribute to spelling issues.

This patch will spell check core if dictionary.txt changes. I also modified the spellcheck:core command by adding the option --no-progress so only error messages are output. That alone makes spell checking core easier. I tested locally and it seems to be working correctly.

Since this is a useful addition for developers, and the lack of this has caused problems and followups I am changing this to a task.

+++ b/core/scripts/dev/commit-code-check.sh
@@ -139,6 +139,10 @@
+

Extra line needs to be removed

No interdiff because this is a small patch

Addressed extra line needs to be removed.

@_utsavsharma, The extra line was removed in #10, no work needed to be done on the patch. The comment states you were addressing the extra line but the patch removed 2 extra lines with no comment as to why. In cases, when a script is being changed we keep to the same code style so it is easy to read an maintain. Therefor, no credit for an unhelpful patch How is credit granted for Drupal core issues → .

The original IS suggests running spellcheck:core only on drupalci. I think it should be done locally to prevent errors when working on spelling issues. It is rare and should be rare that a non-spelling issue is altering the dictionary.

Hiding patches to make clear #10 is the current one.

Code changes make sense to me and will prevent the need for "emergency-repair-commits" when we sometimes forget to run spellcheck locally. So: RTBC.

Committed/pushed to 11.x, thanks!

I don't think we need this in 10.1.x, but if we do, happy to cherry-pick.

Automatically closed - issue fixed for 2 weeks with no activity.

Went ahead and cherry-picked now we're trying to sort out cspell linting with gitlab.