23:19 11:40 Running- 🇮🇳India gauravvvv Delhi, India
I have attached patch for same, please review
- Status changed to Needs work
over 1 year ago 4:13pm 29 September 2023 - last update
over 1 year ago Build Successful - Status changed to Needs review
over 1 year ago 5:16am 2 October 2023 - last update
over 1 year ago 30,360 pass - 🇮🇳India gauravvvv Delhi, India
Tried fixing failures, attached interdiff for same
- Status changed to RTBC
over 1 year ago 6:00pm 2 October 2023 - last update
over 1 year ago 30,371 pass - Status changed to Needs review
over 1 year ago 10:40am 4 October 2023 - 🇫🇮Finland lauriii Finland
Looks like there are couple contrib modules using this session storage entry. Should we deprecate the old key before removing it?
- Status changed to Needs work
over 1 year ago 2:55pm 4 October 2023 - 🇮🇳India yash.rode pune
How can we apply javascript deprecation → on top of this session storage key?
- Status changed to Needs review
7 months ago 11:21am 14 June 2024 - Status changed to Needs work
7 months ago 5:02am 26 June 2024 - Status changed to Needs review
7 months ago 5:39am 26 June 2024 - Status changed to Needs work
6 months ago 8:55pm 15 July 2024 - 🇺🇸United States smustgrave
Deprecation key seems straight forward. But should the message include a link to a CR or mention what should be used instead?
- Status changed to Needs review
6 months ago 4:55am 16 July 2024 - Status changed to RTBC
6 months ago 1:55pm 16 July 2024 - 🇺🇸United States smustgrave
Short and to the point!
Kernel failure appeared to be random, re-ran the tests all are green.
Believe this one is good to go.
- Status changed to Needs work
6 months ago 8:57am 17 July 2024 - 🇫🇷France nod_ Lille
CR was a bit too short, added a bit of context :) Since this is sessionStorage there is no need to get rid of the old variable, it will be deleted when the tab closes.
I know it's now in the toolbar module but it's something that is used in gin, will be used by the navigation module eventually, and the toolbar module will be deprecated/removed at some point. So not sure it's necessary to namespace it in the toolbar. We'd need to do another deprecation later and we don't need to go through that I think.
Can we do
Drupal.escapeAdminPath
instead?