I was working on
#3195568: [PP-1] Support recursive discovery for migration plugins →
and noticed we're using a custom Drupal\Component\FileSystem\RegexDirectoryIterator to iterate over the directory files and apply the regex filter.
new \RegexIterator(new \FilesystemIterator($path), 'pattern');
Actually, that's not true, because the \FilesystemIterator() will iterate over SplFileInfo objects, which returns full path name in toString() method. It makes it harder to set a regular expression for the file name. For example, '/^\d/' pattern won't match 1.yml file.
I think what we can do here - change the base class of RegexDirectoryIterator to simplify the class. Instead of \FilterIterator, we can use \RegexIterator, which already accepts a pattern.
Change the base class of RegexDirectoryIterator;
Nope.
Fixed
10.1 ✨
Last updated
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Seems like a valid addition and don't think it will need any kind of change record.
Nice clean-up. Committed/pushed to 10.1.x, thanks!