- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:28am 5 May 2023 - 🇩🇪Germany Anybody Porta Westfalica
Super helpful addition, just thought the same! We'll review this, thanks!
- First commit to issue fork.
- @grevil opened merge request.
- Status changed to Needs work
over 1 year ago 10:51am 6 June 2023 - 🇩🇪Germany Grevil
The patch works great! Nice job! :)
I'll also add alias_keeper as a default setting, and then we can RTBC this I guess! (There are currently no tests and the schema config definitely needs further entries, but this is too much for this issue).
- Status changed to Needs review
over 1 year ago 11:53am 6 June 2023 - Status changed to RTBC
over 1 year ago 12:43pm 6 June 2023 - thakurnishant_06 India
Hello Folks !!
Tested the MR for node_keep 2.x-dev on Drupal 9.5.9 and PHP 8.2, It works great .
To provide you with a comprehensive view, I will be adding both a before and after screenshot.Can be moved to RTBC!!!
Thank you for your support!!
- Status changed to Needs work
over 1 year ago 1:21pm 6 June 2023 - 🇩🇪Germany Anybody Porta Westfalica
Thank you for the screenshots!
Back to NW for some final fixes:
- The Prevent this node's alias from being changed option is missing in the defaults form
- It isn't clear from the current defaults UI, that the value set is the default for new created nodes of this type. There's currently a too high risk of misunderstanding or in other words, the current texts are wrong.
You can see both points in the screenshots.
These are the two checkboxes appearing on the node create / edit form for comparison:
Prevent this node's alias from being changed
This option will prevent node alias changes to avoid accidents. Only users with "administer node_keep per node" permission will be able to change this node alias.Prevent this node from being deleted
This option will prevent node deletion to avoid accidents. Only users with "administer node_keep per node" permission will be able to remove this node. - 🇩🇪Germany Grevil
@Anybody
1. No its not missing.
2. I'll change that accordingly! - Status changed to Needs review
over 1 year ago 2:14pm 23 June 2023 - Status changed to RTBC
over 1 year ago 3:57pm 23 June 2023 - 🇩🇪Germany Anybody Porta Westfalica
Great work @Grevil! Thank you so much. RTBC! Let's get this merged :)
- 🇩🇪Germany Anybody Porta Westfalica
PS: Super helpful feature, I hope a maintainer will pick this up soon :)
- First commit to issue fork.
- Status changed to Fixed
over 1 year ago 7:01am 3 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.