- 🇷🇸Serbia finnsky
I got same results in Chrome Firefox and Safari for that codepen.
https://codepen.io/finnsky/pen/eYxgLQO
`hidden` actually hide div with class CSS specificity.
But failure in cascade selector and obviously when !important. - Status changed to Needs review
10 months ago 12:33pm 7 November 2023 - 🇷🇸Serbia finnsky
Hi all!
From my point of view we should not optionally use these functions as such. And those scripts that continue to be used are given a warning. Perhaps less strict. So that these warnings can pass functional tests.
For reliable hiding, I added [data-hidden] as suggested.
And reworked layout-builder.js for an example of work.
I also think that .show() and .hide() are not the only functions that can be handled this way. So I renamed the script.
I need a review of the approach here
- Status changed to Needs work
8 months ago 5:15pm 7 January 2024 - 🇺🇸United States smustgrave
Seems to have open threads but appears to have a failure in 5277, can the other MR be closed or hidden?
- First commit to issue fork.
- Status changed to Needs review
7 months ago 7:48am 14 February 2024 - 🇷🇺Russia kostyashupenko Omsk
To test replace
"lint:core-js-passing": "node ./node_modules/eslint/bin/eslint.js --quiet --config=.eslintrc.passing.json .",
by
"lint:core-js-passing": "node ./node_modules/eslint/bin/eslint.js --config=.eslintrc.passing.json .",
and run
yarn lint:core-js-passing
- 🇺🇸United States smustgrave
smustgrave → changed the visibility of the branch 3167377-rewrite-jquery-.show to hidden.
- 🇺🇸United States smustgrave
smustgrave → changed the visibility of the branch 11.x to hidden.
- Status changed to Needs work
6 months ago 5:59pm 14 March 2024 - 🇺🇸United States smustgrave
Hiding patches and old MRs for clarity
Current MR 5277 appears to have a test failure and may need a rebase (maybe it fixes the test)