- First commit to issue fork.
- 🇷🇸Serbia krug
Drupal Version: 8.9.20
Better Exposed Filters better_exposed_filters 8.x-5.2
Views exposed form layout vefl_bef 8.x-3.0
Patch #2 works for me.
@emixaam, thanks. - 🇺🇸United States crutch
Unable to install vefl because requirement "Better Exposed Filters (>=8.x-4.x) (incompatible with version * ? *)"
D 9.5.9
BEF 6.0.3
VEFL 8.x-3.0 - 🇦🇹Austria maxilein
This error also happens on
D 10.2.3
BEF 6.0.3
VEFL 8.x-3.1Does the patch also work with BEF 6?
- 🇷🇸Serbia krug
Drupal Version: 10.2.2
VEFL: 8.x-3.1
BEF: 6.0.3
Patch #2 works for me.
@emixaam, thanks. - 🇹🇷Turkey Orkut Murat Yılmaz
Drupal Version: 10.2.2
VEFL: 8.x-3.1
BEF: 6.0.3
DB: PostgreSQL 15.6Patch #2 works for me as well:)
Any chance for merge?
- 🇵🇹Portugal jrochate
What about this issue 🐛 Compability issue with BEF 6.0.3 Needs review ? The patch it's similar but a few more instructions.
- 🇨🇳China jungle Chongqing, China
Every time the BEF module changes the signature of __construct(), this module breaks. So I would suggest keeping __construct() untouched. And inject the vefl.layout service in create(), see the code snippet below, with this approach, 🐛 Compability issue with BEF 6.0.3 Needs review is a duplicate to me.
/** * The vefl layout helper. * * @var \Drupal\vefl\Vefl */ protected $vefl; /** * {@inheritdoc} */ public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) { $instance = parent::create($container, $configuration, $plugin_id, $plugin_definition); $instance->vefl = $container->get('vefl.layout'); return $instance; }
- Status changed to Needs work
2 months ago 3:22am 23 April 2024 - Status changed to Needs review
2 months ago 3:48am 23 April 2024 - 🇨🇳China jungle Chongqing, China
Patch updated per #21, the link https://git.drupalcode.org/project/vefl/-/merge_requests/1.diff
- 🇦🇹Austria maxilein
#23 fixed it for me.
D10.2.5
php8.1I had the following recent error. #2 did not work any longer.
ArgumentCountError: Too few arguments to function Drupal\better_exposed_filters\Plugin\views\exposed_form\BetterExposedFilters::__construct(), 7 passed in /.../web/modules/contrib/vefl/modules/vefl_bef/src/Plugin/views/exposed_form/VeflBef.php on line 89 and exactly 8 expected in Drupal\better_exposed_filters\Plugin\views\exposed_form\BetterExposedFilters->__construct() (line 84 of /.../web/modules/contrib/better_exposed_filters/src/Plugin/views/exposed_form/BetterExposedFilters.php).
- 🇺🇸United States castella
#23 fixed it for me as well.
Attached is a patch file to use in the meantime. - 🇩🇪Germany NWOM
#23 and #25 both wouldn't apply for me. Here is a new patch that works against 8x-3.1
- Status changed to RTBC
26 days ago 7:54am 1 June 2024 - 🇹🇷Turkey Orkut Murat Yılmaz
I'm changing the status as RTBC. Thanks for the patch.