Compability issue with BEF 8.x-5.0, BEF 6.0.3, BEF 7.0

Patch #2 works!

Drupal Version: 8.9.20
Better Exposed Filters better_exposed_filters 8.x-5.2
Views exposed form layout vefl_bef 8.x-3.0
Patch #2 works for me.
@emixaam, thanks.

Unable to install vefl because requirement "Better Exposed Filters (>=8.x-4.x) (incompatible with version * ? *)"

D 9.5.9
BEF 6.0.3
VEFL 8.x-3.0

This error also happens on

D 10.2.3
BEF 6.0.3
VEFL 8.x-3.1

Does the patch also work with BEF 6?

Changed because the patch works for BEF 6.0.3 also.

Drupal Version: 10.2.2
VEFL: 8.x-3.1
BEF: 6.0.3
Patch #2 works for me.
@emixaam, thanks.

Drupal Version: 10.2.2
VEFL: 8.x-3.1
BEF: 6.0.3
DB: PostgreSQL 15.6

Patch #2 works for me as well:)

Any chance for merge?

What about this issue 🐛 Compability issue with BEF 6.0.3 Needs review ? The patch it's similar but a few more instructions.

Every time the BEF module changes the signature of __construct(), this module breaks. So I would suggest keeping __construct() untouched. And inject the vefl.layout service in create(), see the code snippet below, with this approach, 🐛 Compability issue with BEF 6.0.3 Needs review is a duplicate to me.

  /**
   * The vefl layout helper.
   *
   * @var \Drupal\vefl\Vefl
   */
  protected $vefl;

  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
    $instance = parent::create($container, $configuration, $plugin_id, $plugin_definition);
    $instance->vefl = $container->get('vefl.layout');
    return $instance;
  }

Patch updated per #21, the link https://git.drupalcode.org/project/vefl/-/merge_requests/1.diff

#23 fixed it for me.
D10.2.5
php8.1

I had the following recent error. #2 did not work any longer.

ArgumentCountError: Too few arguments to function Drupal\better_exposed_filters\Plugin\views\exposed_form\BetterExposedFilters::__construct(), 7 passed in /.../web/modules/contrib/vefl/modules/vefl_bef/src/Plugin/views/exposed_form/VeflBef.php on line 89 and exactly 8 expected in Drupal\better_exposed_filters\Plugin\views\exposed_form\BetterExposedFilters->__construct() (line 84 of /.../web/modules/contrib/better_exposed_filters/src/Plugin/views/exposed_form/BetterExposedFilters.php).

#23 fixed it for me as well.
Attached is a patch file to use in the meantime.

#23 and #25 both wouldn't apply for me. Here is a new patch that works against 8x-3.1

I'm changing the status as RTBC. Thanks for the patch.

It is not working with the latest BEF 7.0, although the patch applies.

It just gives a WSOD.
Apache error log:

PHP Fatal error: Type of Drupal\\vefl_bef\\Plugin\\views\\exposed_form\\VeflBef::$filterWidgetManager must be Drupal\\better_exposed_filters\\Plugin\\BetterExposedFiltersWidgetManager (as in class Drupal\\better_exposed_filters\\Plugin\\views\\exposed_form\\BetterExposedFilters) in /var/www/modules/contrib/vefl/modules/vefl_bef/src/Plugin/views/exposed_form/VeflBef.php on line 22, referer: https://testsite/admin/people?user=gab&status=All&role=All&permission=All

Added a separate MR for BEF 7.0. Wasn't sure if adding the additional changes to the existing MR would affect anyone referencing the MR directly in some way.

@fskreuz.
Thank you. the 7.0 patch works.

Same issue with BEF v6.0.6.

This will be always an issue if BEF is going to keep changing their create() and __construct() signatures all the time. Additionally, VeflTrait has a very obscure dependency on the Vefl service, which doesn't really exist in Vefl trait, but rather is expected to be added in the "treated" class.

The way to decouple from this is to provide Vefl service along with the trait, as a getter for example. There are a few traits in the core that use this approach, so we can call this an acceptable practice.

Another confusing thing is when an inherited member from a base class is overridden by a member inserted by a Trait, but this is a different story.

I am adding another merge request to help with the service dependency.