Filter button in User interface translation form has more whitespace than it needs

Created on 17 July 2020, almost 4 years ago
Updated 30 April 2024, about 2 months ago

Problem/Motivation

Enable locale, head to admin/config/regional/translate, and notice that the filter button has more distance between it and other elements than seems necessary.

This may impact other forms, this is just where I happened to notice it.

Proposed resolution

  • Get agreement that this should be changed
  • If there is agreement to change, determine the change that should be made
  • Determine if this impacts other forms
  • Impement, check for side effects in other forms

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Needs work

Version

11.0 🔥

Component
Claro  →

Last updated about 1 hour ago

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India Gauravvv Delhi, India

    Re-rolled Patch #11, as it's no longer applies to 10.1.x.

  • Status changed to RTBC about 1 year ago
  • 🇮🇳India ameymudras

    Ive tested the patch on 10.1.x and following are my findings

    1. The Issues summary is clear and explains the problem
    2. Was able to replicate the problem
    3. The patch applies cleanly
    4. The patch fixes the issue and eliminates the extra space.
    5. Did a code review and its a simple change to offload the locale.admin.css css as per #10

    Moving the issue to RTBC, skipping before / after screenshots, since a few have been already provided

  • Status changed to Needs work about 1 year ago
  • 🇫🇮Finland lauriii Finland

    I am not sure we should actually get rid of this CSS file completely. The file seems to contain several UX enhancements to the translation related UIs. They may seem minor but I assume some thought has been put behind them.

  • Status changed to Needs review about 2 months ago
  • 🇮🇳India Gauravvv Delhi, India

    The updated solution as per #23 no longer removes the locale.admin.css file. Instead, it adds `padding-block-start: 0;` for the button. Please review

  • Pipeline finished with Success
    about 2 months ago
    Total: 578s
    #160335
  • 🇮🇳India divya.sejekan

    Verified for both D10 and D11 . The fix looks fine.
    Verified using MR - 3159892-filter-button-in

    Testing steps :
    1. Enable language module
    2. Navigate to /admin/config/regional/translate
    3. Check the filter button

    RTBC ++
    Keeping in Review state for further review

  • 🇮🇳India Kanchan Bhogade

    Hi
    Tested MR !7841 on Drupal 11
    MR is applied Cleanly...

    Test Result:
    The Filter Button extra whitespace reduced and it looks good now.

    RTBC+1

    Adding screenshots for reference

  • Status changed to Needs work about 2 months ago
  • 🇺🇸United States smustgrave

    Looking just at the issue summary

  • Get agreement that this should be changed
  • = can it be pointed out where the agreement was

  • If there is agreement to change, determine the change that should be made
  • = same

  • Determine if this impacts other forms
  • = was this done? Definitely don't see

  • Impement, check for side effects in other forms
  • = related to above

Production build 0.69.0 2024