- 🇮🇳India gauravvvv Delhi, India
Re-rolled Patch #11, as it's no longer applies to 10.1.x.
- Status changed to RTBC
over 1 year ago 1:35pm 20 March 2023 - 🇮🇳India ameymudras
Ive tested the patch on 10.1.x and following are my findings
1. The Issues summary is clear and explains the problem
2. Was able to replicate the problem
3. The patch applies cleanly
4. The patch fixes the issue and eliminates the extra space.
5. Did a code review and its a simple change to offload the locale.admin.css css as per #10Moving the issue to RTBC, skipping before / after screenshots, since a few have been already provided
- Status changed to Needs work
over 1 year ago 8:48am 21 March 2023 - 🇫🇮Finland lauriii Finland
I am not sure we should actually get rid of this CSS file completely. The file seems to contain several UX enhancements to the translation related UIs. They may seem minor but I assume some thought has been put behind them.
- Merge request !7841spacing fixed above filter button on translate page → (Open) created by Unnamed author
- Status changed to Needs review
7 months ago 3:36am 30 April 2024 - 🇮🇳India gauravvvv Delhi, India
The updated solution as per #23 no longer removes the locale.admin.css file. Instead, it adds `
padding-block-start: 0;
` for the button. Please review - 🇮🇳India divya.sejekan
Verified for both D10 and D11 . The fix looks fine.
Verified using MR - 3159892-filter-button-inTesting steps :
1. Enable language module
2. Navigate to /admin/config/regional/translate
3. Check the filter buttonRTBC ++
Keeping in Review state for further review - 🇮🇳India Kanchan Bhogade
Hi
Tested MR !7841 on Drupal 11
MR is applied Cleanly...Test Result:
The Filter Button extra whitespace reduced and it looks good now.RTBC+1
Adding screenshots for reference
- Status changed to Needs work
7 months ago 2:00pm 30 April 2024 - 🇺🇸United States smustgrave
Looking just at the issue summary
- Get agreement that this should be changed
= can it be pointed out where the agreement was
- If there is agreement to change, determine the change that should be made
= same
- Determine if this impacts other forms
= was this done? Definitely don't see
- Impement, check for side effects in other forms
= related to above