Change implementation details of UpdateManagerUpdateForm to use install/uninstall

This makes the suggested changes. It also includes changing some comments.

believe these should be changed too

'#prefix' => '<h2>' . $this->t('Disabled') . '</h2>',

$form['projects']['#prefix'] = '<h2>' . $this->t('Enabled') . '</h2>';

The changes asked for in #10 are for the UI. This issue is for the implementation details, the UI is done in a sibling issue.

In that case think this is good.

Needs reroll now that 🐛 Change UI for /admin/reports/updates/update to not mention "Enabled/Disabled" modules and themes Fixed landed.

The last submitted patch, 14: 3121870-14.patch, failed testing. View results →

Thanks for working on this! I had forgotten this issue existed.

dww%  egrep -ir disabl core/modules/update/src/Form |  wc
      15      87    1638
dww% git apply 3121870-16.patch 
dww% egrep -ir disabl core/modules/update/src/Form | wc

So that's good. 😅

Sadly, there are still a ton of references outside of that directory:

dww% egrep -ir disabl core/modules/update | wc
      52     684    7708

We'll need another child (or children?) of 📌 [meta] Update module terminology still refers to disabled extensions when it should be uninstalled Active for that...

I think the patch looks okay, but I need to do a more careful review of the surrounding code to make sure we're only changing internal stuff here, not the structure of any monster ArrayPI arrays.

I think it would be better to have followups made as a child of the parent so a followup is not considered a step before this is committed. I am removing the tag. I've updated the IS in the parent to be clear that two of the remaining tasks need issues made.

I looked at the changes in #14 and #15, which I agree with. But I can't RTBC this issue.

But I can! haha

This is actually changing both enable and disable, so updating title.

The last submitted patch, 16: 3121870-16.patch, failed testing. View results →

Rerunning but believe to be unrelated.

The last submitted patch, 16: 3121870-16.patch, failed testing. View results →

Unrelated failure, retesting

1) Drupal\Tests\Component\Utility\RandomTest::testRandomMachineNamesUniqueness
RuntimeException: Unable to generate a unique random machine name

Restoring RTBC

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Converted to an MR

Hiding patches for clarity.

Was previously RTBC so restoring status.

Committed b102e5e and pushed to 11.x. Thanks!

Not eligible for backport due to user facing string changes and some internal API changes that, while unlikely to affect anyone, we don't want to drop into a patch release.

quietone → closed merge request !5525

Automatically closed - issue fixed for 2 weeks with no activity.