- 🇮🇳India sonam.chaturvedi Pune
Verified and tested patch #17 on 10.1.x-dev. Patch applied cleanly and works fine.
Test Result:
Only the block name is styled as disabled. All the other columns and interactive elements -i.e. Region, "Enable" button are in style indicating that they are accessible/enabled.Please refer attached before and after screenshots for Claro, Olivero and Seven themes.
Accessibility review required.
- Status changed to RTBC
over 1 year ago 11:14pm 12 March 2023 - 🇺🇸United States smustgrave
Actually since I did not work on the fix, just the test case I think I'm still okay to review this one. And since it's not causing an accessibility issue per #22 think it's good.
- Status changed to Needs work
over 1 year ago 11:00am 17 March 2023 - 🇫🇮Finland lauriii Finland
There are still a few things that we probably should still iterate on:
The "disabled" style still applies to the table drag handle. I believe it might be confusing because at first I thought for real that maybe it is disabled because it was the only interactive element on the row that was indicating it's disabled.
When hovering a disabled table row, different columns are now using different background color.