Routes fail validation in link field widgets

Another issue with the current getUriAsDisplayableString approach is that route:entity.group_content.canonical;group_content=135&group=3 gets truncated to ntity.group_content.canonical;group_content=135&group=3. That is an outright bug.

Here we add some test coverage and rebase this as a patch on 10.1.x.

Why did we remove the Text-only links. test cases? Because there is dedicated test coverage, it wasn't needed and the regex parsing was causing errors on those test cases.

The last submitted patch, 20: 3115188-20.patch, failed testing. View results →

Random test failure.

Ran the test locally without the fix and it failed as expected

Behat\Mink\Exception\ExpectationException : The string ""route:entity.node.canonical;node=1"" was not found anywhere in the HTML response of the current page.

So removing the tag.

The change in question seems good though.

+++ b/core/modules/link/tests/src/Functional/LinkFieldTest.php
@@ -160,11 +162,6 @@ protected function doTestURLValidation() {
-      // Text-only links.
-      '<nolink>' => '&lt;nolink&gt;',
-      'route:<nolink>' => '&lt;nolink&gt;',
-      '<none>' => '&lt;none&gt;',

why are we removing these?

Can we also get a red/green set of patches here demonstrating the new test failures?

Thanks

I think we also want a change notice for this detailing the official support for route:

Removing getUriAsDisplayableString makes sense.

It fixes the situation for me too.

+1 for patch in #20.

Just been hit by the problem today.

Spent a bunch of time to understand what was going on and finally found this issue.

Hoping to have it fixed one day 🙏 😉

re #25:

See #21. More specifically, testNoLinkUri. Since doTestURLValidation has duplicate coverage that is difficult to handle with the way that regex works, I removed it as opposed to adding one-off logic for it.

Added a CR and uploading a test-only patch. The full patch is a duplicate of #20.

The last submitted patch, 29: 3115188-29-test-only.patch, failed testing. View results →

Please review.

The last submitted patch, 31: 3115188-31.patch, failed testing. View results →