The Needs Review Queue Bot โ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 7:18am 7 April 2023 - ๐ฎ๐ณIndia gauravvvv Delhi, India
As stable and seven are no longer part of 10.1.X. Patch #38, no longer applies. I have added an updated patch. please review
- Status changed to Needs work
over 1 year ago 2:36pm 7 April 2023 - ๐บ๐ธUnited States smustgrave
Was previously tagged for tests. Can probably do simple assertions
This seems tied to ๐ Remove redundant WAI-ARIA role attributes from , , , , and elements Needs work so maybe they should be combined or least share a change record.
If kept separate think this one needs to get in first over ๐ Remove redundant WAI-ARIA role attributes from , , , , and elements Needs work as that one removes redundant roles but aside tags would still be wrong until this lands.
- ๐จ๐ฆCanada mgifford Ottawa, Ontario
Adding WCAG SC 4.1.2 https://www.w3.org/WAI/WCAG21/Understanding/name-role-value
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Iโm triaging for DrupalCon mentored contribution and reviewing as this issue is tagged novice.
*******
Please leave this issue for DrupalCon mentored contribution as a possible first time issue.*******
The patch is simple and passes tests. Smustgrave noted maybe other issues should be considered at the same time as this but, even so, tests can be added to this patch.
This issue requires someone who knows how to code. They donโt necessarily need to know how to create tests and could be mentored on that.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Tag normalization happening:)