Ajax replace inside a modal causes the current field to lose focus.

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Re-rolled #12

error: patch failed: core/misc/dialog/dialog.ajax.js:21
error: core/misc/dialog/dialog.ajax.js: patch does not apply

Still needs tests.

Some of the underlying logic was changed in 🐛 Dialog focus is returned to dialog instead of first tabbable element on dialog AJAX update Fixed , so at the very least this needs to be rewritten.

Rerolled, but it doesn't seem to work?

In my scenario I'm using Layout Builder to control the fields on an inline block. The block has two text fields followed by a paragraphs field. When either click "Edit" to show the fields for the paragraph, or click the "add" button to add another paragraph item, the same thing happens - the focus moves to the first field of the block, not the first field of the paragraph.

The patch in #23 doesn't change this behavior - after the AJAX operation has completed the focus is returned to the top item in the modal, not the top of the fields newly added to the form, which is the expected behavior.

This problem was originally brought to my attention during an accessibility review, so I figured it should be flagged as such.