- Issue created by @lauriii
- Status changed to Needs review
about 1 year ago 6:18pm 30 October 2023 - Status changed to Needs work
about 1 year ago 10:40pm 31 October 2023 - 🇮🇳India yash.rode pune
yash.rode → made their first commit to this issue’s fork.
- Status changed to Needs review
12 months ago 8:05am 23 November 2023 - 🇫🇮Finland lauriii Finland
@yash.rode can you summarize here what was the change in behavior you noticed when you updated the tests?
- 🇮🇳India yash.rode pune
The change in tests is regarding the lines where we tried checking if the focus is on the form/content, but now we need that focus to be on the first tabbable element present on that modal.
- Status changed to Needs work
12 months ago 2:43pm 23 November 2023 - 🇺🇸United States smustgrave
Hate to do it but just to remain consistent with other tickets, can the issue summary be updated with steps to reproduce, what the proposed solution was, maybe any before/after screenshots if possible.
- First commit to issue fork.
- Status changed to Needs review
12 months ago 5:10am 29 November 2023 - Status changed to RTBC
12 months ago 9:18pm 29 November 2023 - 🇺🇸United States smustgrave
Confirmed the fix following the steps in the issue summary. Using just my keyboard
Created a field
Selected a reference field if that matters
Tabbed and clicked change field
Focus is on the first option - Status changed to Needs work
12 months ago 8:25am 30 November 2023 - 🇫🇮Finland lauriii Finland
It looks like this introduces changes to the media focus handling which is probably not desired. I think we need to try to find a way to fix the media focus handling so that we don't need to update tests related to it.
- Status changed to Needs review
12 months ago 12:30pm 30 November 2023 - Status changed to RTBC
12 months ago 2:33pm 30 November 2023 - 🇺🇸United States smustgrave
Seems feedback has been addressed.
Though wonder if a follow up is open for
I think we need to try to find a way to fix the media focus handling so that we don't need to update tests related to it.
and a todo needs to be added?
- Status changed to Needs work
12 months ago 2:42pm 30 November 2023 - Status changed to Needs review
12 months ago 11:25am 4 December 2023 - Status changed to RTBC
12 months ago 9:18pm 4 December 2023 - 🇺🇸United States smustgrave
Limited knowledge of the js api but appears feedback was addressed.
- Status changed to Fixed
12 months ago 8:59am 5 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
5 months ago 9:04am 2 July 2024 This brought a new problem to me. When I removed the image or deleted the item in the dialog, the focus jumped to the top of the dialog.
I added a patch to fix this issue.
- 🇺🇸United States edwardsay
@mark-shi I had a similar issue, and your patch fixed it. I use the Layout Paragraphs module, where the paragraph form opens in a modal. Whenever I uploaded an image to the field or added a nested paragraph, the modal would scroll to the top, and the first focusable element would receive focus. This scrolling jump made content editing quite frustrating.