Dialog focus is returned to dialog instead of first tabbable element on dialog AJAX update

Seems to have a test failure.

yash.rode → made their first commit to this issue’s fork.

@yash.rode can you summarize here what was the change in behavior you noticed when you updated the tests?

The change in tests is regarding the lines where we tried checking if the focus is on the form/content, but now we need that focus to be on the first tabbable element present on that modal.

Hate to do it but just to remain consistent with other tickets, can the issue summary be updated with steps to reproduce, what the proposed solution was, maybe any before/after screenshots if possible.

Confirmed the fix following the steps in the issue summary. Using just my keyboard
Created a field
Selected a reference field if that matters
Tabbed and clicked change field
Focus is on the first option

It looks like this introduces changes to the media focus handling which is probably not desired. I think we need to try to find a way to fix the media focus handling so that we don't need to update tests related to it.

addressed #14

Seems feedback has been addressed.

Though wonder if a follow up is open for

I think we need to try to find a way to fix the media focus handling so that we don't need to update tests related to it.

and a todo needs to be added?

Posted feedback in the MR

Limited knowledge of the js api but appears feedback was addressed.

lauriii → closed merge request !5192

Committed 762fcae and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

This brought a new problem to me. When I removed the image or deleted the item in the dialog, the focus jumped to the top of the dialog.
I added a patch to fix this issue.

@mark-shi I had a similar issue, and your patch fixed it. I use the Layout Paragraphs module, where the paragraph form opens in a modal. Whenever I uploaded an image to the field or added a nested paragraph, the modal would scroll to the top, and the first focusable element would receive focus. This scrolling jump made content editing quite frustrating.