๐Ÿ‡บ๐Ÿ‡ธUnited States @edwardsay

Account created on 16 January 2017, about 8 years ago
#

Merge Requests

More

Recent comments

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

edwardsay โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

edwardsay โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

MR was updated, conflicts were fixed

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Conflicts were resolved, and the patch can be applied to 2.x version of the module

https://git.drupalcode.org/project/csv_importer/-/merge_requests/18.patch

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

edwardsay โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Added MR for Facets v3, which adds hierarchy plugin form in Facet Views filter - https://git.drupalcode.org/project/facets/-/merge_requests/270
Also, added a small MR which gives access to the facet object inside the Hierarchy plugin - https://git.drupalcode.org/project/facets/-/merge_requests/271

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Added MR that renders Hierarchy plugin config form.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

edwardsay โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Updated patch that can be applied to 1.0.1

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Created new MR https://git.drupalcode.org/project/layout_paragraphs_limit/-/merge_reque... that is mergeable into 1.0.x

(Patch https://git.drupalcode.org/project/layout_paragraphs_limit/-/merge_reque... can only be used if you use the dev version of the module. If you use the stable 1.0.1 version the patch is in the #13 comment)

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

I have partially addressed the "duplicate" control issue and also, created a patch that can be applied to 1.0.1

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

edwardsay โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

With D10 version of the module this issue is even more problematic, as in D10 all users have "authenticated" role by default. In our case, even Admin users couldn't use "Admin" IMCE profile, because authenticated role was picked up first by userProfile() method in Imce.php and limited IMCE profile for authenticated users was used. Reordering of the Roles does help, but it a very unreliable approach.
Patch was implemented to accommodate this issue: https://git.drupalcode.org/project/imce/-/merge_requests/34.patch

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

edwardsay โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

I discovered a new issue related to the RenderedItem processor and access caching.

It's a unique situation: I have nodes with a paragraphs field and the Paragraphs Role Visibility module enabled, so different roles see different sets of paragraphs. Additionally, I have rendered_item fields in my search index, each configured to render a full node for a specific role.

However, due to access caching in EntityAccessControlHandler, all rendered_item index fields are populated with the same value during reindexing. This happens because, even though the set of roles differs for each index field, the User ID is the same (specifically, it defaults to 0 if a patch for this issue isn't applied). EntityAccessControlHandler::getCache() uses only the User ID and doesnโ€™t distinguish between caches for different roles.

I resolved this issue by setting a random UID for the dummy user in the RenderedItem processor.

I've created a new merge request to address this issue: https://git.drupalcode.org/project/search_api/-/merge_requests/188

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

edwardsay โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay
๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

edwardsay โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

@mark-shi I had a similar issue, and your patch fixed it. I use the Layout Paragraphs module, where the paragraph form opens in a modal. Whenever I uploaded an image to the field or added a nested paragraph, the modal would scroll to the top, and the first focusable element would receive focus. This scrolling jump made content editing quite frustrating.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

The module does not work on 10.3:
Fatal error: Access level to Drupal\config_view\Plugin\views\query\ConfigViewQuery::$offset must be public (as in class Drupal\views\Plugin\views\query\QueryPluginBase) in /app/web/modules/contrib/config_view/src/Plugin/views/query/ConfigViewQuery.php on line 23"
Attached is the patch that resolves this issue

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Patch #12 applies and works great! That's exactly what we needed.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

@robpowell Could expand on this, please? What do you mean by "changed this to the view's facet summary"?

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Thank you, @tgoeg

I completely agree regarding the necessity of separate servers for production and development environments. However, due to constraints, I had to devise a solution without completely altering the project architecture. Implementing a few Meilisearch instances on the same servers but with different ports is a fantastic idea, which I briefly mentioned as one possible approach in the description.

Using index prefixes is a common practice. For instance, this functionality is available in the Search API Solr Drupal module. Therefore, I believe it would be beneficial to incorporate this feature into the Search API Meilisearch module.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Even the closing of the dialog triggers the refocus and scroll. A new GIF is attached.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Thank you Wim Leers.

Unfortunately, the fix from https://www.drupal.org/comment/15443030#comment-15443030 โ†’ does not resolve the issue related to the jQuery focus event, triggered on the CKE buttons.

This "jump issue" can be reproduced not only in CKE-Templates dialogs, but all dialogs.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Unfortunately, patch #5 does not work for me. It affects the "Insert selected" button, but not the close X button of the dialog itself. So when I close dialog the page jumps to the top of the CKE5 editor.

The JS solution from https://www.drupal.org/project/drupal/issues/3410598 ๐Ÿ› CKEditor 5: scroll jump after dialog close Active works for drupalMedia CKE plugin too, though.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Adding 10.2 support for patch #3

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

@dbielke1986 Yes, we use Anchor Link 3.0.0-alpha2 and it works well.

However, this particular issue is unrelated to the Anchor Link CKEditor plugin. This is solely related to the Linkit plugin.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

This issue was reported as problematic for cases when you need to add an anchor to the node URL.

I created a patch to address this issue. The autocomplete menu item will be automatically selected on the autocomplete menu close if it's the only item available. This patch can be applied to Linkit module version 6.1.0

Attached is a .gif with the demonstration of how the link to Node with anchor will work after applying the patch.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

This issue was partially resolved in Drupal Core 10.2 because it uses CKEditor version 40.

After the update, there is no "This link has no URL" tooltip when clicking on the end of the link. But it is still present when clicking on the start of the link.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Added support for drupal-entity-inline in CKEditor 5

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Code style improvement.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Patch works, but not in case the form element in the exposed form is placed inside a container or other wrapper. I added support for this case. Also, I faced an issue with the "reset" button while testing this patch: validation didn't let me perform the reset action. So I added improvement for that case as well.

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

Patch to add description support

๐Ÿ‡บ๐Ÿ‡ธUnited States edwardsay

I have added a patch from comment 2 to the merge request. Also, made two fixes:
1. Added support for search_api_term filter plugin.
2. Changed selector to exposed-form submit button in JS. I think it will be useful because when the exposed-form is in a separate block submit is a not .

https://git.drupalcode.org/project/views_filters_summary/-/merge_request...

Production build 0.71.5 2024