"This link has no URL" when inserting text before or after a link

Thanks for the GIF illustrating the problem. I've encountered this problem, too. I assume it has to do with CKEditor 5's upcasted version of the element having a greedy boundary.

Setting the priority to "Major," as this could cause headaches for content editors.

Update: this is still considered a "Major" level bug for Linkit, and is still prioritized.

The issue is present, even with the patch applied.

FYI https://ckeditor.com/docs/ckeditor5/latest/features/link.html#typing-aro...

The last submitted patch, 10: 3364963-this-link-has-no-url-10.patch, failed testing. View results →

#10 fixes it but it completely breaks linkit functionality, data attributes are missing entirely.

acbramley → changed the visibility of the branch 6.1.x to hidden.

acbramley → changed the visibility of the branch 3364963-this-link-has to hidden.

This issue was partially resolved in Drupal Core 10.2 because it uses CKEditor version 40.

After the update, there is no "This link has no URL" tooltip when clicking on the end of the link. But it is still present when clicking on the start of the link.

Updated the MR and added a new patch against 6.1.x

The last submitted patch, 16: 3364963-this-link-has-no-url-16.patch, failed testing. View results →

CkEditor does special link handling if the element attribute data model name starts with "link", eg. "linkHref" or "linkWhatever".

LinkIt uses ['data-entity-type', 'data-entity-uuid', 'data-entity-substitution'] for both the attribute model and view names.

So because the model names don't start with "link", CkEditor thinks it should inherit the previous element attributes like for bold or other styling.

The fix is to split out the attribute vars so the model names start with "link" and the view names stay the same.

Attached patch tested with Drupal 10.1.8 and LinkIt 6.1.3.

Marking as Needs Review. Sorry if this is not the appropriate workflow, ie. this is missing tests or anything else.

drpldrp → changed the visibility of the branch 6.1.x to active.

drpldrp → changed the visibility of the branch 6.1.x to hidden.

The explanation for the root cause, provided in #18, makes sense to me, above, and the code change looks valid. Tests pass, so let's merge this!

Amazing, thanks everyone! And thanks a lot @mark_fullmer for including this in a release already :)

Automatically closed - issue fixed for 2 weeks with no activity.