Contrib.social

Layout Builder omits view-mode class when editing layout

Open on Drupal.org →
Created on 23 November 2019, about 5 years ago
Updated 11 February 2023, almost 2 years ago

Problem/Motivation

When editing a layout, the page is missing some html elements and classes, which results in some of CSS rules being ignored.

In umami, on a Recipe page, there's an html element "article", with the classes node node--type-recipe node--promoted node--view-mode-full

When editing the layout of that recipe page, the article html element with its classes are not on that page, which causes the 4 icons (background images) to not show up.

This is a follow-up from #3085534: Configure Umami to use Layout Builder to deliver original recipe content type designs →

In Comment #18, it was reported that the icons for "Preparation", "Cooking Time" etc do not show in Layout Builder. Since this issue was not introduced by the patches in that issue, we are creating a follow-up issue here instead to see if we can fix it.

Frontend - Umami Recipe Icons:

Layout Builder - Umami Recipe Icons are not visible

Proposed resolution

TBD

Remaining tasks

Add tests
Code review

User interface changes

TBD

API changes

TBD

Data model changes

TBD

Release notes snippet

TBD

🐛 Bug report
Status

Needs work

Version

10.1 ✨

Component
Layout builder  →

Last updated 4 days ago

Created by

🇮🇪Ireland markconroy

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇮🇳India Rinku Jacob 13 Kerala

    I have Reviewed the Merge request !2352 on drupal version 10.1.0-dev. Tested the issue on a individual node. the patch work perfectly for me. adding screenshots for the references.
    Testing Steps
    .Install a new drupal site(select profile as umami)
    .Select Recipes menu from Main navigation.
    .Select any view recipe link.
    .click on layout option.
    .Test the changes before and after applying the merge request

  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    This will require a test case to show the issue. Will add to remaining tasks.

    This also needs an issue summary update for proposed solution.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024