Remove hardcoded plugin IDs from migration process plugins

This accepts the changes in #19. And adds potential fixed for BlockVisibility and FilterFormatPermissions. Not very pretty but I think it will work.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

It is more important that this is reviewed for the approach so setting back to NR.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Went to take a look at the MR but showing 1000+ changes which doesn't seem correct. Wonder if the MR could be fixed. Not sure what changes to look out.

Hiding patches as fix is now being worked on in MR 3198

Wasn't entirely too sure how to test.
Setup a fresh D10.1 site and D7 site
Installed the migrate modules

Did some edits to a User Login block on D7
But because of BlockVisibility.php in the IS
Changed the visibility and block title.
Ran the import and didn't receive any issues.
Block changes were imported correctly.

if there are additional changes please let me know and can test.

Rereading the IS I think the proposed resolution needs an update, which I have done.

There are no unanswered questions her, although I do not see a code review since #19, and more changes were added since then. Setting back to NR for review.

Did the testing in #45

I'm triaging RTBC issues → . I read the IS and the comments, also noted that tests are not running regularly.

This is tagged for "Needs architectural review" but there is no such review, so setting to NR.

I also rebased the MR

Setting to NW to add documentation to all plugins we are creating or changing, and for a CR.

Think a rebase went wrong as the MR is showing 1000+ file changes.

I have updated this to complete the support of previously generated d6_block and d7_block migrations.

Change record added.

And I did a more thorough self review. I found that this included changes for a different issue, so I removed those. I reworked logic in BlockVisibility and d6/FilterFormatPermission process plugins.

This still need subsystem maintainer review?

Appears feedback has addressed.

core/modules/block/src/Plugin/migrate/process/RolesLookup.php to add documentation I see there is example code

* Examples
*
* @code
* process:
* roles:
* plugin: roles_lookup
* migration: d7_user_role
* @endcode

I had an issue where block configs for a ton of my blocks, including content blocks, were failing to come in. MR #3198 fixed that problem, all my blocks that are content blocks migrated properly 🎉 A few remaining issues, and I don't know if they're related to *this* issue! -- and I don't have a ton of info yet, I just tried the patch on Friday, I'll continue hammering away at the remaining missing blocks this week and share more if I have more to share --

Meanwhile, my remaining issues that may or may not be relevant to *this* issue:

• "Seven" blocks came in with "seven" in the block machine name, but "claro" in the actual theme setting in the block.
  • In other words, the block machine names are, for example seven_user_login (but the theme setting is "theme: claro", as it should be -- so the blocks are properly configured, it's just the wrong theme name in the machine name).
  • Definitely not the end of the world, but, sharing!
• Views blocks didn't come in.
• Menu Block module blocks didn't come in.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Thank YOU @catch! Great to see this fixed finally :)

quietone → closed merge request !3198

Automatically closed - issue fixed for 2 weeks with no activity.