- Status changed to Needs work
almost 2 years ago 11:38am 17 January 2023 - Status changed to Needs review
almost 2 years ago 10:02am 6 February 2023 - Status changed to Needs work
almost 2 years ago 11:02am 10 February 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 1:18pm 22 February 2023 - Status changed to Needs work
almost 2 years ago 3:29pm 3 March 2023 - 🇺🇸United States smustgrave
Know this is a task but seems like we could have test coverage.
Feel we can add a simple assertion to an existing test somewhere testing for the new class.
And the fact we changed the autocomplete class and nothing broke feels like it never had test coverage.
- First commit to issue fork.
- Status changed to Needs review
almost 2 years ago 6:55pm 3 March 2023 - Status changed to RTBC
almost 2 years ago 9:45pm 3 March 2023 - Status changed to Needs review
almost 2 years ago 7:16pm 10 March 2023 - 🇺🇸United States rpayanm
Added the @lauriii's suggestions, please review.
- Status changed to Needs work
almost 2 years ago 11:12pm 12 March 2023 - 🇺🇸United States smustgrave
Maybe it's a nightwatch test? But since we are adding a js deprecation now think we will need a simple assertion verifying the deprecation is working.