Deprecate \Drupal\Component\FileSystem\FileSystem::getOsTemporaryDirectory() and replace with sys_get_temp_dir()

Unfortunately missed the D10 window

And still needs windows testing. (Can't do as I'm on a mac)

Added patch against #26 in 10.1 version

+++ b/core/lib/Drupal/Component/FileSystem/FileSystem.php
@@ -13,8 +13,14 @@ class FileSystem {
+   * @deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use
...
+    @trigger_error(__METHOD__ . ' is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use sys_get_temp_dir() instead. See https://www.drupal.org/node/3225275', E_USER_DEPRECATED);

message should be changed to 10.1.0 and 11.0.0

Made changes as per comment #35.

See my patch in #26

+++ b/core/tests/Drupal/Tests/Component/FileSystem/LegacyFileSystemTest.php
@@ -0,0 +1,28 @@
+  public function testDeprecatedGetOsTemporaryDirectory() {

this test is missing in last reroll

Raised a MR against 10.x branch from the patch in #26, addressed #35 and #37.

Came here for something else, decided to do a code review instead. 😇

Merge request and changes looks good! @Bhanu951

Still needs review for the manual Windows testing mentioned in #33 also on a Mac/Linux here.

Asked around and can't find anyone on a windows to do testing.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I have a Windows VM on which I could test it. Although it's not the "real deal" of course.