- Status changed to Needs review
almost 2 years ago 4:33am 24 March 2023 - 🇮🇳India gauravvvv Delhi, India
Re-rolled patch #2, for 9.5.x. Patch #2 no longer applies to 9.5.x. Not attaching interdiff as no patch is applying to 9.5
- Status changed to Needs work
almost 2 years ago 2:34pm 25 March 2023 - 🇮🇳India ameymudras
Would be really helpful if we can have testing steps in the description. Couple of suggestions after code review:
1. we can make use of isset instead of array_key_exists since its faster
if (is_array($text) && isset($text['#markup'])) {
2. The following comment needs to be better worded
// Handle strings that are passed in array as value in the #markup key.
- First commit to issue fork.
- @rpayanm opened merge request.
- Status changed to Needs review
almost 2 years ago 2:52pm 25 March 2023 - Status changed to Needs work
almost 2 years ago 9:42pm 25 March 2023 - 🇺🇸United States smustgrave
The issue summary should be updated to include the problem, proposed solution, and remaining tasks
Title also should be updated to show the problem not the ticket number.
Also needs test coverage.