- Status changed to Needs work
almost 2 years ago 11:56pm 30 January 2023 The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- @bnjmnm opened merge request.
- Status changed to Needs review
almost 2 years ago 12:41pm 31 January 2023 - πΊπΈUnited States bnjmnm Ann Arbor, MI
In the time since this issue was filed, the jQuery UI :tabbable selector has been shimmed in core to use the focus-trap/tabbable library instead of jQuery UI's logic #3179734: Refactor uses of the :tabbable selector and deprecate it β .
jQuery UI did not consider summary elements tabbable due to them being inert in IE and pre-Chromium edge. Additional logic was added to the :tabbable shim to preserve this denial of summary elements. Since Drupal 10 does not support IE or pre-Chromium edge, we can remove this additional logic and simply rely on the focus-trap/tabbable library, which addresses the problem this issue was filed to address. - Status changed to Needs work
over 1 year ago 11:43pm 16 February 2023 - πΊπΈUnited States smustgrave
Seems there were some build errors in the MR.
Hiding the files to avoid review confusion.
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Tagging field UX as dialogs are likely to be used more heavily as these changes start happening.
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 11:11am 11 April 2023 - πΊπΈUnited States bnjmnm Ann Arbor, MI
@VladimirAus clicking the rebase button on issues you're not otherwise contributing to is creating unnecessary noise.
- Status changed to RTBC
over 1 year ago 7:33pm 11 April 2023 - πΊπΈUnited States smustgrave
Hooray is right about IE.
This should be important to the field tickets openings in modals now.
- Status changed to Fixed
over 1 year ago 9:53pm 11 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.