If a site only supports a 'throbber' for progress, don't show a summary or gear icon

Created on 3 March 2019, almost 6 years ago

Updated 8 May 2023, over 1 year ago

Problem/Motivation

I originally reported this at #2113931-236: File Field design update: Upload field. → .B:

When I went to configure the widgets on "Manage form display", I noticed a minor UI WTF. The summary says "Progress indicator: throbber" but when I click on the gear icon to see what the other choices are and try them out, there's no setting at all. :/ I guess that's supposed to be at 📌 File Field design update progress bar Active or something, but until that lands, it seems a little cruel and a lot confusing to advertise the "throbber" as a widget option if I can't change it. ;) Can we just rip that out from the settings summary and add it back in once there's a setting we can change that needs to be summarized?

Summary:

Empty widget settings:

I then discovered it has nothing to to with that patch nor 📌 File Field design update progress bar Active , but instead my local dev site didn't have uploadprogress.so enabled. ;)

Splitting this off as a minor UX follow-up...

Note, this might be made obsolete if we get 📌 Add support for built-in PHP session upload progress Needs work working and all sites will always have a bar option available and file_progress_implementation() always returns something (or goes away entirely?).

Proposed resolution

If file_progress_implementation() returns FALSE, theres's no progress bar implementation available, and we only support a throbber, don't show a summary for the progress indicator and don't show a gear icon when configuring a file widget.

Remaining tasks

TBD.

User interface changes

Hide the gear icon and settings summary for field field widget on sites that don't allow you to configure the progress indicator at all.

API changes

Probably none.

Data model changes

None.

Release notes snippet

TBD.

🐛 Bug report

Status

Active

Version

10.1 ✨

Component

File system →

Last updated 4 days ago

Maintained by
🇦🇺Australia @kim.pepper

Created by

🇺🇸United States dww

Live updates comments and jobs are added and updated live.

Usability
Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Novice
It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Bug Smash Initiative

DrupalSouth

Incomplete comments

Merge Requests

!10519If a site only supports a 'throbber' for progress, don't show a summary or gear icon
Open
Unnamed author
updated 27 days ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
First commit to issue fork.
Comment 27 days ago →
starlight-sparkle
Merge request !10519Add a notice to explain why File widget settings might be unavailable → (Open) created by Unnamed author
Pipeline finished with Failed
27 days ago
Total: 472s
#365223
Comment 27 days ago →
starlight-sparkle
I have made a merge request addressing this issue this as part of Drupalcon Singapore 2024 Contribution Day.
@larowan came by and suggested to add a message explaining the empty field rather than altering the behaviour of the edit settings gear icon, as this would require EntityDisplayFormBase::buildFieldRow() to traverse all the nested fields inside of widget settings form to check if they are visible.
Removing the form element from the settings form was also not advisable as this would change the form schema.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024