Hide empty description for an administrative block

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

This still appears relevant and an issue in D10
Will need tests to show the issue and that it's being fixed.

Adding reroll for D10

Please include an interdiff with your patches and please read the comments and tags this needs tests not just a rerolll

Hey @smustgrave I was testing this issue on D10.1, I wasn't able to get the error using claro as admin theme, but using stark, it happened, maybe it also happens on seven, so I've decided to write a test for it. So I'm uploading the test only patch and a new patch for it. It would be nice to have a review here.

The last submitted patch, 15: 3033904-15-test-only-patch.patch, failed testing. View results →

The last submitted patch, 15: 3033904-15.patch, failed testing. View results →

Whoops, let's try it again.

The last submitted patch, 18: 3033904-18-test-only.patch, failed testing. View results →

The test only patch failed so moving back to NR

Can review today but please put the patches in order of

test-only patch
full patch

Or its just going to keep moving to NW

Can review today but please put the patches in order of

Thanks for the review! And also thanks for the order suggestion, the test only patch is always the first to be uploaded.

To make the review easier, I've hidden the test only patch

Great job on the tests!

Tested this out locally by editing the ban module.
Removed the description from ban.links.menu.yml
Using stark theme with description shown.
I can see the empty div.

With the fix I don't see the empty div.

Committed/pushed to 10.1.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.