Undefined index: #parents FormState.php

We also encountered this error after updating core to 9.5.10 and PHP 8.1. I don't remember seeing the error with PHP 8.0.

In our case we seem to get two different warnings:

Warning: Undefined array key "#parents" in Drupal\Core\Form\FormState->getError() (line 1137 of /var/www/html/builds/2023-09-19.10-55-49.tag--0.0.47__db59b9ce6/web/core/lib/Drupal/Core/Form/FormState.php)
 
Warning: foreach() argument must be of type array|object, null given in Drupal\Core\Form\FormState->getError() (line 1137 of /var/www/html/builds/2023-09-19.10-55-49.tag--0.0.47__db59b9ce6/web/core/lib/Drupal/Core/Form/FormState.php) 

I created a new branch and MR 5230 for 11.x. This branch also address the 2 threads on the original MR 1300:

1. "The point of the test is to prove there is no notice - so this name is a bit odd." by @alexpott
   • The class was renamed to "FormAfterBuildTest".
2. "It doesn't trigger a notice any more - right? Is the error handler approach necessary here? I think it's not - we'd error if there was a notice as far as I know." by @alexpott
   • The test was updated to catch any errors when the form is submitted instead of using an error handler.

hiding outdated patches

Attached is a static patch of the MR 5230 at commit 2c405b97. This can be used for consistent composer builds.

Rebased and ran test-only feature for MR 5230. https://git.drupalcode.org/issue/drupal-3027240/-/jobs/272556

They passed when they should have failed.

@smutsgrave I suspect it is how you are testing the "test only". The changes in core/modules/system/tests/modules/form_test/form_test.module are needed for the test but the job https://git.drupalcode.org/issue/drupal-3027240/-/jobs/272556 is reverting that change (see screenshot attached).

attached is a tests only patch of MR5230 at commit 2c405b97. This should fail.

Thanks for the test-only patch. It indeed does show the failure so removing the tests tag.

Change seems fine and hate to do it but could the issue summary be updated also. Solution "Apply patch" isn't a real solution description and could be kicked back just for that. Issue summary is to help the committer understand the issue and what the fix is.

Thanks!

Thanks!

I'm triaging RTBC issues → . I read the IS and the comments.

I think the following still need to be answered
#50 🐛 Undefined index: #parents FormState.php RTBC
#37 🐛 Undefined index: #parents FormState.php RTBC
and are mentioned in #55 as a point of concern.

I am setting to needs work for those items.

FWIW - I managed to stumble in here while trying to add an error to an #item FAPI element. My particular case (heavy in custom code territory) is that I have a third party javascripty thing (reCAPTCHA) that needs to block form submit in certain cases.

$element['error'] = [
  '#type' => 'container',
  'recaptcha_error_message' => [
    '#type' => 'item',
    '#markup' => ''
  ]
];

// Sometime later...

$form_state->setError($element['error']['recaptcha_error_message'], $error);

I wonder -- are there certain FAPI element types that simply weren't intended to support error messages associated with them?

Ran into an issue today that triggered this. The patch from MR! 1300 fixed our issue.

The code that fixes this was vastly simplified since comments #57, #55 and #37 effectively deprecating those comments.

This is a very simple change with an automated test that has a test only failure.

It is needed.

alexpott → changed the visibility of the branch 3027240-undefined_parents to hidden.

alexpott → changed the visibility of the branch 11.x to hidden.

alexpott → changed the visibility of the branch 10.1.x to hidden.

alexpott → changed the visibility of the branch 9.3.x to hidden.

Added some questions/comments to the MR

Also #55 is not addressed in comments.

Also #50 is not really addressed either - i.e. the part about what the form system adds to all elements by default and will be missing if you add elements in after build.

Added patch of MR5230 for use in composer.
Applies to 11.x and 10.3.x