Translations directory not autocreated

Just ran into this issue once again. It would be great to fix this, since it can be pretty annoying such as breaking CI pipelines when installing modules.

Could we move this issue forward? I guess the comments in #25 are still valid?

Re rolling patch 30 for latest Drupal 10.2.x

I made a mistake re-rolling 35, so I've re-rolled a new patch to resolve the issue which should apply cleanly against latest 10.2.x

The MR !8320 should address the feedback from #25.3 and #25.5, but I wonder what action (if any) should be taken for other comments on #25, so marking this "Needs review".

I feel the priority should be raised, because this issue is typical for causing frustration, since the the UI doesn't give a proper indication of what is wrong with settings.

MR works fine. Tested drush locale-update and translations update via UI

I have mixed feelings about this issue.

I think the missing translation directory in your dev situation for example is a lack of syncing files in your development workflow. Other critical files may also be missing. Eg. the JS translation files may get regenerated locally and that may end up leading to a mismatch in your live site when the updates get pushed (depending on what you push).

At the same time I understand the developer experience improvement that instead of an error, you get an empty directory at least. I am not sure though if that does not lead to unwanted side effects.

How are other files missing handled by Drupal? Eg. if your site logo is missing or other key files that you don't have on the dev environment?

One MR specific comment: How is the locale/src/Plugin/QueueWorker/LocaleTranslation.php change related?

Should this be in PNMI ?

To address some of the questions in #42

How are other files missing handled by Drupal? Eg. if your site logo is missing or other key files that you don't have on the dev environment?

I don't think its recommended to include files from sites/default/files to version control. If the theme build assets are not included in version control and the build process fails, at least there's visual cue that the files are missing. When translation directory missing, the error message on UI/watchdog doesn't give guidance how to resolve the issue. I added the screenshot of the error message on UI to issue summary.

For code specific discussion I think the comments on merge request would be preferred, but locale/src/Plugin/QueueWorker/LocaleTranslation.php change is needed because LocaleTranslation::processItem() provides zero $args. The tests where failing without this change.

Indeed that error message is not helpful. Could the error be more specific and tell the user the directory does not exist? What can the user then do to get the directory created? (Save the file settings config form?) At least if we let the user know this, they have a chance to sync their translation files if they wish so without silently getting them into a different situation.

Thanks so much for taking a look @gábor hojtsy moving to NW to address the feedback.

re: #46
Asking users to go to separate form to resolve this issue does not help the command-line use cases (CI pipelines, syncing database from different environment, etc.).

IMHO automatically creating the missing translation directory gives the best DX/UX. We could add some message to inform about autocreation.

I have run into this a few times with CI pipelines and it is a bit of an annoyance. I agree with sokru that we should handle it automatically if it doesn't exist. I can't see a downside to having it there, even if it is empty.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

MR updated + missing typehints.

We could add some message to inform about autocreation.

Think would be a good compromise