Patch #46 breaks due to upstream change in Drupal Core 10.3 InlineBlockEntityOperations, see commit: https://git.drupalcode.org/project/drupal/-/commit/71a1ab746b9731cb30213.... This change removes the parent getPluginBlockId method and causes a WSOD. It looks like that method was getting the plugin id from configuration so the patch could likely be updated to code around this. I don't see this patch as long term viable unless core allows for these classes and services to be open to contrib projects so we are planning on getting out of this patch.
RTBC, any chance we can get this reviewed by a maintainer since this could cause issues once 10.3 is released
@Vivek Panicker my apologies, I've added those contributions. Thanks.
I've merged this, thanks for the contribution.
adam-delaney → created an issue.
Applying patch from #2 resolves this issue for me RTBC.
I've created a new patch from patch 44 that removes the services.yml in favor of a ServiceProvider that dynamically defines inline_entity_form.get_block_dependency_subscriber if block_content is enabled. I have also checked that block_content is enabled in hook_entity_presave() as that was erroring as well.
> The LB module declares its event subscriber in a ServiceProvider class instead of in its .services.yml file. This is because it is conditional: it should only be defined if the block_content module is enabled. This patch just declares the subscriber in the .service.yml file, but perhaps it would be better to use a ServiceProvider class. I have not tested whether this patch causes problems when LB is not enabled.
I've tested this with a new site install that does not enable block_content and this will throw the following error: `Error: Class "Drupal\block_content\BlockContentEvents" not found in Drupal\inline_entity_form\EventSubscriber\SetInlineBlockDependencyNested::getSubscribedEvents()`
Thanks Dave! Tested and works as expected.
Looks like changes in your pull request (https://git.drupalcode.org/project/library_attach/-/merge_requests/1) are passing CI (https://git.drupalcode.org/project/library_attach/-/jobs/761744) and would solve this issue. Thanks Dave for looking into that. A release with this fix would be great!
Based upon composer's documentation this appears to be a valid constraint using Hyphenated Version Range, see: https://getcomposer.org/doc/articles/versions.md#hyphenated-version-range-. I wonder if it cannot be used in combination with wildcard?
adam-delaney → created an issue.
I believe this issue has been resolved with the release of drupal/bynder 4.2.0, see: https://git.drupalcode.org/project/bynder/-/commit/ce6422e5271fb4e97127d...
I made a mistake re-rolling 35, so I've re-rolled a new patch to resolve the issue which should apply cleanly against latest 10.2.x
Re rolling patch 30 for latest Drupal 10.2.x
Per this doc: https://www.drupal.org/docs/theming-drupal/z-indexes-in-drupal-8 → , the jquery-ui dialog should have a z-index of 1260. After a brief investigation it not's clear to me how to set the z-index for that element. From what I can tell there is no code in the module that is responsible for setting that.
adam-delaney → created an issue.
I've tested Drupal 10.1 with a clean install using the steps in the description to reproduce the issue and I'm not able to reproduce it. This seems to have been fixed in states.js for Drupal 10.
I've tested the 4.x-dev version with the following patches against a Drupal 9 site:
- "Issue #2940967: Allow drush uli logins": "web/profiles/contrib/houston/patches/upstream/2940967-allow-drush-uli-login.patch"
- "Issue #3332611: Saving a user overrides the authname": "web/profiles/contrib/houston/patches/upstream/3332611-4.diff"
Everything works as expected.
Thanks for getting this merged. Could we get a stable release cut for this?