- 🇺🇸United States smustgrave
So all this empty space seems awkward to me. Tagged for usability for their opinion.
Adding a new action I also expected to be able to set category but could not.
- Status changed to Needs review
almost 2 years ago 6:13am 10 February 2023 - 🇳🇿New Zealand danielveza Brisbane, AU
Category is defined on the Action plugin itself, not via the UI.
Setting back to needs review, leaving the usability review tag.
- Status changed to Needs work
almost 2 years ago 10:43pm 21 March 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- @arunkumark opened merge request.
- Status changed to Needs review
almost 2 years ago 7:22am 22 March 2023 - 🇮🇳India arunkumark Coimbatore
Patch has been re-rolled and created the MR
- Status changed to Needs work
almost 2 years ago 8:07am 22 March 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 10:57am 22 March 2023 - Status changed to Needs work
almost 2 years ago 3:16pm 28 March 2023 - 🇳🇱Netherlands yoroy
Well yes, lets at the very least not add empty table columns :)
I'm wondering about the relative impact of this change. Did we find a little gap between a code comment that indicates a non existing UI, or is Actions module really in need of/would greatly benefit from categorizing individual actions? Also, "categories" is not really used elsewhere in core is it?
If it's only a code comment that hints at something we don't really miss, than the cheaper fix might be to rewrite that comment?
- First commit to issue fork.
