Add a new permission for 'Field list' report

Confirmed in 11.x, updated IS to be a bit more clear.

Updated IS with the simple solution to just use a different permission. I can't say I use this report very often so not sure that it needs the most robust option :)

Updated to use 'View site reports' permission. Couldn't see any tests for this to update, please don't say it needs one :)

Made a follow up to remove it. 📌 Consider removing the 'Field list' reports Active

So there was a test of the page itself, which failed because the test user was only granted specific permissions. Anyway good news that there sort of already is a test that failed. Updated, should be green now.

Moving this to needs work so I can figure out how this permission change would affect existing sites. I assumed that anyone who used this report already had 'view site reports' but the test indicates otherwise.

Back to needs review, I think the choices are either:

1. Commit as a simple permissions change, noting that it would affect existing sites. I think the impact is mitigated by the fact that someone who didn't have view reports access would be unlikely to know about the report since they would not have the reports page in the toolbar.
2. Create a new permission for this report and add it for users who previously had 'Administer content types'
3. Won't fix?

I think for minimum disruption we would add a new perm, an update hook that adds it to roles with the existing one, etc.

I could imagine sites that want to give out ‘view site reports’ to roles for whom a complete list of all entity types and fields would be inappropriate, overwhelming, etc.

This page probably wants to live under Structure, not Reports, anyway, but that’s for another issue. 😅 It does seem like a useful report to get a sense of the IA of a site, especially if you didn’t build it yourself.

Not sure what to recommend here. 🙃 I completely defer to the committers for a way forward.

Not a core committer but I agree with @dww in #22 about adding a new permission to avoid disruption. Can image this route there being confusion about this link randomly appearing for users.

I have been thinking about this and I really don't think it's a bug. It was built this way intentionally and I don't think it's broken, but it could be improved. So I've updated it to a feature request.

No one besides the OP has ever raised this, and although several people have noted the report's utility, none have noted any concerns with the current permission setup. This isn't that surprising because the report is really only useful to site admins who are reviewing the sites content model.