Update viewsreference_update_8103 fails if table name is too long and shortened by Drupal

The last submitted patch, 20: 2925609-20.viewsreference.Update-viewsreferenceupdate8103-fails-if-table-name-is-too-long-and-shortened-by-Drupal.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Yay, got the tests to run. Thanks so much for the work on this. It would be great to get this in, I think this is the most important stable blocker at the moment.

Here is a first update simply fixing the PHPCS errors in #20.

Locally I'm getting a different error than DrupalCI:

There should be no errors in configuration 'core.entity_view_display.node.page.default'. Errors:
Schema key core.entity_view_display.node.page.default:content.field_viewsreference.settings.plugin_types.default failed with: variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\StringData
Schema key core.entity_view_display.node.page.default:content.field_viewsreference.settings.plugin_types.page failed with: variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\StringData
Schema key core.entity_view_display.node.page.default:content.field_viewsreference.settings.plugin_types.feed failed with: variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\StringData

Don't have the time to dig deeper at the moment, but hopefully, someone else can continue now we have the tests running!

The last submitted patch, 29: 2925609-29.patch, failed testing. View results →

Data can be empty (NULL) therefore I added a check and defaulted the value to empty array.

Also I created a new dump with 2 revision.

+ Some more asserts.

To test the scope I added also a field to a term.

test only patch.

Lets skip the test for D10.

The last submitted patch, 34: 2925609-34.test-only.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Coding standards.

On a _quick_ passthrough of this code I noticed that the ${var} syntax is being used in strings. PHP 8.2 doesn't like that ;)

Perhaps consider using sprintf to prepare the table/column names?

Hi, could you give a solution for this in code please? Thanks!

Great job on the tests, thanks! I think it would be nice to fix #38 as well. After that, it would really help to a bit more people to test this. But since this is a stable blocker I would really like to get this in asap.

#37 worked for me. Here's an updated version that addresses #38 by changing "${field_name}_..." to "{$field_name}_...".

+1 RTBC

Sharing that the patch at #41 has worked here too. Thanks so much for the push!

Finally got around to commit it. Thanks everyone for your hard work! ❤️
This is a great step towards getting 2.x stable!

Automatically closed - issue fixed for 2 weeks with no activity.

We forgot to include removing all unchecked viewsreference "plugin_types", "preselect_views" and "enabled_settings" field settings.

Before this patch, we had no schema definition for "plugin_types", "preselect_views" and "enabled_settings" AND no fieldSettingsFormValidate() method, which simply removes all unchecked setting values before form submission. So the module used to save both unchecked and checked field settings in config. If the value was checked, it saved the name of the value as a string (e.g. page:page) or if it was uncheckd as "0" (e.g. page: 0).

After this patch, the empty values are not getting saved anymore, but they still exist in config if not manually resaved. And since "viewsreference.plugin_types" and "preselect_views" (also "enabled_settings" now through 🐛 Configuration schema for "Enable extra settings" (title,pagination,...) incorrect Fixed ), are defined as sequences of strings, but the old implicit schema definition for an unchecked value was integer, the following error will appear using config_inspector:

variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\StringData

Here is an exported config as an example, showing the old unchecked values still saved:

  plugin_types:
    default: default
    page: page
    block: block
    attachment: attachment
    feed: feed
    entity_browser: 0
  preselect_views:
    admin_header_slides: 0
    block_content: 0
    content: 0
    content_recent: 0
    files: 0
    frontpage: 0
    glossary: 0
    media_library: 0
    redirect: 0
    redirect_404: 0
    scheduler_scheduled_content: 0
    taxonomy_term: 0
    user_admin_people: 0
    user_profile_display: 0
    watchdog: 0
    webks_inhalt_unterseiten: 0
    who_s_new: 0
    who_s_online: 0
  enabled_settings:
    argument: argument
    offset: 0
    limit: 0
    pager: 0
    title: title

I will create a follow-up issue for this.

Done, see here: 🐛 Add missing update hook for adjusting viewsreference field settings RTBC .