"Add new comment" and "@count comments" links are not following accessibility good practices

Open on Drupal.org →

Created on 10 November 2017, over 6 years ago

Updated 16 May 2023, about 1 year ago

Problem/Motivation

Since Drupal 7, the "Read more" links added by the core on the nodes teasers have been made accessible by appending them a visually-hidden indication of the node title to read more about. The same thing should be done on the "Add new comment" and "@count comments" links provided by the comment module.

This is important because screen readers users sometime navigate by jumping from link to link. If the links titles are such generic, they have no clue about where they are going to land.

Steps to reproduce

Install Drupal standard
Create an article, published ans promoted to front page, with title "Blah"
Go to your article and add a comment
Have a look at your front page source code

Expected result: <a href="/node/1#comments" title="Jump to the first comment." hreflang="en">1 comment<span class="visually-hidden"> on Blah</span></a> and <a href="/node/1#comment-form" title="Share your thoughts and opinions." hreflang="en">Add new comment<span class="visually-hidden"> about Blah</span></a>

Current result: <a href="/node/1#comments" title="Jump to the first comment." hreflang="en">1 comment</a> and <a href="/node/1#comment-form" title="Share your thoughts and opinions." hreflang="en">Add new comment</a>

Proposed resolution

Use the same trick than "Read more" links.

Remaining tasks

User interface changes

Nothing visual. Screen readers are going to find more context on "Add new comment" and "@count comments" links.

API changes

None.

Data model changes

None.

🐛 Bug report

Status

Needs work

Version

10.1 ✨

Component

Last updated 5 days ago

Maintained by
🇦🇺Australia @larowlan
🇫🇷France @andypost

Created by

🇫🇷France DuaelFr Montpellier, France

Live updates comments and jobs are added and updated live.

Accessibility
It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

Bug Smash Initiative

Needs Review Queue Initiative

wcag244

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇸United States smustgrave
Can the MR be updated for 10.1 please or a separate one opened please.
Comment over 1 year ago →
System Message
DuaelFr → closed merge request !1283
@duaelfr opened merge request.
Status changed to Needs review over 1 year ago8:52am 13 February 2023
Comment over 1 year ago →
🇫🇷France DuaelFr Montpellier, France
@smustgrave Done :)
Status changed to Needs work over 1 year ago5:05pm 13 February 2023

Comment over 1 year ago →

🇺🇸United States smustgrave

Thanks!

Seems there is a failure in MR 3455


Remaining self deprecation notices (84)

  52x: Deprecated NULL placeholder value for key (@title) in: "Add new comment about @title". This will throw a PHP error in drupal:11.0.0. See https://www.drupal.org/node/3318826
    52x in CommentLinkBuilderTest::testCommentLinkBuilder from Drupal\Tests\comment\Unit

  32x: Deprecated NULL placeholder value for key (@title) in: "1 comment on @title". This will throw a PHP error in drupal:11.0.0. See https://www.drupal.org/node/3318826
    32x in CommentLinkBuilderTest::testCommentLinkBuilder from Drupal\Tests\comment\Unit

Comment about 1 year ago →
🇨🇦Canada mgifford Ottawa, Ontario
Adding SC for 2.4.4
https://www.w3.org/WAI/WCAG21/Understanding/link-purpose-in-context

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024