- 🇬🇧United Kingdom alexpott 🇪🇺🌍
@sardara do you feel like rtbc'ing this again. The change looks good.
- Status changed to RTBC
over 1 year ago 6:52am 9 March 2023 - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
This change looks great, the test coverage is very small but seems to cover everything in this patch. I don't mind the code duplication here because it looks more clear with it being inline in this case.
- 🇮🇹Italy sardara
I arrive late, but indeed I agree with the changes and the RTBC.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 66500ab088 to 10.1.x and 0769b54d48 to 10.0.x and 5ad06dcc0e to 9.5.x. Thanks!
-
alexpott →
committed 66500ab0 on 10.1.x
Issue #2881077 by smustgrave, sardara, amcgowanca, alexpott, dawehner:...
-
alexpott →
committed 66500ab0 on 10.1.x
- Status changed to Fixed
over 1 year ago 9:04am 9 March 2023 -
alexpott →
committed 0769b54d on 10.0.x
Issue #2881077 by smustgrave, sardara, amcgowanca, alexpott, dawehner:...
-
alexpott →
committed 0769b54d on 10.0.x
-
alexpott →
committed 5ad06dcc on 9.5.x
Issue #2881077 by smustgrave, sardara, amcgowanca, alexpott, dawehner:...
-
alexpott →
committed 5ad06dcc on 9.5.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed to 10.1.x, 10.0.x, and 9.5.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.