🇮🇹Italy @sardara

Merged, thanks.

The fix and tests look good.

I tested it now and it works correctly with a real CAS implementation. Tests are looking good too.

Looks good, thanks for the changes.

Good, ready to be merged.

Added review.

greggles → credited sardara → .

The issue is not caused by media_avportal but by monolog, see 🐛 NullLogger not implements LoggerChannelInterface Fixed .
Additionally, changing the signature would considered a backwards compatibility break.

I've tested the pull request and it works correctly.

Merged, thanks again @darvanen!

sardara → made their first commit to this issue’s fork.

Old CI disabled. Thanks @darvanen!

Thanks @darvanen for the issue.
Regarding cspell, we can fix the labels, they are mostly in comments and tests. Let's do it in a follow-up.
For phpstan, I guess for now we just ignore it. We will handle it later on.
Phpunit is probably failing due to HTML structure changes, I agree to move it.

sardara → made their first commit to this issue’s fork.

It needs tests before RTBC.

Test coverage has to be added.
Off the top of my head, I think I didn't add support for nested elements because of the possibility of having #tree set to true or false, making it hard to handle complex cases. Please test that scenario when adding tests.

Looks good, just the change in the summary, is it only to be concise? It seems unrelated at a first look.

The bug happens for me mostly during tests. It can be reproduced via drush php:

\Drupal::configFactory()->getEditable('cas.settings')->set('logout.cas_logout', TRUE)->save();
\Drupal::service('router.no_access_checks')->match('/user/logout');

#7 fixes the issue.

Uploading the MR code as patch for direct reference.

Ok, tests on D10 seem to be red aside from the changes of this PR.

I am not sure if we should add an update path to re-save the roles that have a permission assigned.

sardara → created an issue.

sardara → made their first commit to this issue’s fork.

Updating the patch of #74 to use the new once library (see change record → ), so that patch is compatible with D10.
Also fixed two 2 deprecation warnings.

Test is now executed

Tests to be run:
18:57:00   - Drupal\Tests\file_link\Kernel\FileLinkWidgetTest
18:57:00   - Drupal\Tests\file_link\Kernel\FileLinkValidationTest
18:57:00   - Drupal\Tests\file_link\Kernel\FileLinkMultiValueTest
18:57:00   - Drupal\Tests\file_link\Kernel\FileLinkDeferredTest

sardara → created an issue.

Tests fail as expected
Twig\Error\SyntaxError: Unknown "spaceless" tag.

sardara → created an issue.

I arrive late, but indeed I agree with the changes and the RTBC.

Looks good, +1.

The last patch/MR works looks good. Tested locally a configuration export and worked as expected.

sardara → made their first commit to this issue’s fork.

smustgrave → credited sardara → .