- Issue created by @darvanen
- last update
7 months ago 12 pass - last update
7 months ago 12 pass - last update
7 months ago 12 pass - Issue was unassigned.
- Status changed to Needs review
7 months ago 10:38am 24 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
I've put the template in place, I only enabled the "next minor" test because the module does not yet advertise compatibility with the next major. I didn't bother with "previous major" because Drupal 9 is EOL.
The few phpcs errors were easily fixed so I did that.
CSpell fails mostly because of the use of UK rather than US English (the latter being the Drupal standard). Didn't know whether you'd want that being messed with so I disabled that test.
The next minor phpstan test is failing because of https://www.drupal.org/node/3436275 → . I've asked in the #contribute channel in Slack for some advice around that. We could disable the next minor test but that would only work until 10.3 is released, at which point something will need to be done. I'd suggest moving forward with the rest of this issue and making a follow-up for that.
Not sure why phpunit is failing on the next minor, I think that too needs a follow-up.
Marking NR for maintainer input/direction.
- 🇮🇹Italy sardara
Thanks @darvanen for the issue.
Regarding cspell, we can fix the labels, they are mostly in comments and tests. Let's do it in a follow-up.
For phpstan, I guess for now we just ignore it. We will handle it later on.
Phpunit is probably failing due to HTML structure changes, I agree to move it. - Status changed to Fixed
7 months ago 10:59am 24 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
Follow ups:
- 📌 CSpell - enable and fix Active
- 🐛 PHPUnit failure with Drupal 10.3 Active
- Status changed to Needs work
7 months ago 1:13pm 24 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
Still one step to go here - remove the old Drupal CI on this page: https://www.drupal.org/node/3184173/qa →
I'm afraid I can't do that one, maintainer access only.
- Status changed to Fixed
5 months ago 2:53pm 26 June 2024 - Status changed to Fixed
5 months ago 2:53pm 26 June 2024