SQL migrate id_map plugin should use MigrateMapSaveEvent fields, not the original ones

Added tests, plus a slight re-roll to use the modern dispatcher argument order. No interdiff due to small size.

Leaning on #mikelutz expertise on this one.

I did verify the tests added fail as expected
testSetFields

Error : Call to undefined method Drupal\migrate\Event\MigrateMapSaveEvent::setFields()

Nothing seems wrong to me with this solution.

Add a return type to the new method, changed a comment and removed unneeded double quotes.

Remarking and removing credit for sonam_sharma for the empty commit.

About credit, I wonder why I'm not listed there ? I created the issue and original patch.

@fgm The issue still needs to be marked Fixed. Hopefully, the maintainer who commits the changes will verify whom needs to get credited.

Yes, part of the process for making a core commit → is to review the credit on an issue and update it. But while I am here I will add fgm.

Needed a reroll

Reroll seemed good so restoring previous status.

The Needs Review Queue Bot → tested this issue. We recommend that you convert this patch to a merge request.

Merge requests are preferred over patches. Be sure to hide the old patch files as well (converting an issue to a merge request without other improvements is not recommended and will not receive credit).

Saving issue credits.

Just some small nitpicks.

1. +++ b/core/modules/migrate/src/Event/MigrateMapSaveEvent.php
   @@ -57,4 +57,14 @@ public function getFields() {
   +   * @param array $fields
   
   +++ b/core/modules/migrate/tests/src/Unit/Event/MigrateMapSaveEventTest.php
   @@ -0,0 +1,87 @@
   +  /**
   +   * A test field array.
   +   *
   +   * @var array
   

   Can we be more specific than array here? From the test data, it looks like it can be a string or an int, so mixed[].

2. +++ b/core/modules/migrate/tests/src/Unit/Event/MigrateMapSaveEventTest.php
   @@ -0,0 +1,87 @@
   +   * A test id map.
   

   "ID" should be in caps.

3. +++ b/core/modules/migrate/tests/src/Unit/Event/MigrateMapSaveEventTest.php
   @@ -0,0 +1,87 @@
   +   * @var \Drupal\migrate\Plugin\MigrateIdMapInterface|object|null
   +   */
   +  protected ?MigrateIdMapInterface $map = NULL;
   

   The documented generic object here contradicts the strictly typed property typehint.

4. +++ b/core/modules/migrate/tests/src/Unit/Event/MigrateMapSaveEventTest.php
   @@ -0,0 +1,87 @@
   +  protected $fields = [
   

   Missing typehint.

5. +++ b/core/modules/migrate/tests/src/Unit/Event/MigrateMapSaveEventTest.php
   @@ -0,0 +1,87 @@
   +  public function testGetFields() {
   ...
   +  public function testGetMap() {
   ...
   +  public function testSetFields() {
   

   Missing return typehints (which should be void).

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other improvements is not recommended and will not receive credit.)